On Sunday 20 April 2008, David Miller wrote: > From: Ingo Molnar <mingo@xxxxxxx> > Date: Sun, 20 Apr 2008 10:13:02 +0200 > > > drivers/built-in.o: In function `rt2x00leds_resume': > > : undefined reference to `led_classdev_resume' > > drivers/built-in.o: In function `rt2x00leds_resume': > > : undefined reference to `led_classdev_resume' > > [...] > > > > config: > > > > http://redhat.com/~mingo/misc/config-Sun_Apr_20_09_43_01_CEST_2008.bad > > Thanks for your report. > > This is a similar case to the iwlwifi build failure you reported > earlier today (where the leds infrastructure knob is modular but the > driver using the interfaces is built-in). Therefore, it likely should > use select too. > > This should fix it: > > rt2x00: Select LEDS_CLASS instead of using 'depends'. > > Based upon a build failure reported by Ingo Molnar. > > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx> > > diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig > index a1e3938..ab1029e 100644 > --- a/drivers/net/wireless/rt2x00/Kconfig > +++ b/drivers/net/wireless/rt2x00/Kconfig > @@ -60,7 +60,8 @@ config RT2400PCI_RFKILL > > config RT2400PCI_LEDS > bool "RT2400 leds support" > - depends on RT2400PCI && LEDS_CLASS > + depends on RT2400PCI > + select LEDS_CLASS Not sure about it, but doesn't LEDS_CLASS depend on NEW_LEDS ? Which would make selecting LEDS_CLASS broken when NEW_LEDS isn't enabled? > select RT2X00_LIB_LEDS > ---help--- > This adds support for led triggers provided my mac80211. > @@ -86,7 +87,8 @@ config RT2500PCI_RFKILL > > config RT2500PCI_LEDS > bool "RT2500 leds support" > - depends on RT2500PCI && LEDS_CLASS > + depends on RT2500PCI > + select LEDS_CLASS > select RT2X00_LIB_LEDS > ---help--- > This adds support for led triggers provided my mac80211. > @@ -114,7 +116,8 @@ config RT61PCI_RFKILL > > config RT61PCI_LEDS > bool "RT61 leds support" > - depends on RT61PCI && LEDS_CLASS > + depends on RT61PCI > + select LEDS_CLASS > select RT2X00_LIB_LEDS > ---help--- > This adds support for led triggers provided my mac80211. > @@ -130,7 +133,8 @@ config RT2500USB > > config RT2500USB_LEDS > bool "RT2500 leds support" > - depends on RT2500USB && LEDS_CLASS > + depends on RT2500USB > + select LEDS_CLASS > select RT2X00_LIB_LEDS > ---help--- > This adds support for led triggers provided my mac80211. > @@ -148,7 +152,8 @@ config RT73USB > > config RT73USB_LEDS > bool "RT73 leds support" > - depends on RT73USB && LEDS_CLASS > + depends on RT73USB > + select LEDS_CLASS > select RT2X00_LIB_LEDS > ---help--- > This adds support for led triggers provided my mac80211. > Ivo -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
