Re: [PATCH 8/8] [NETFILTER]: xt_length match, revision 1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 2008-04-09 18:25, Patrick McHardy wrote:
>
> In my opinion all the kernel should needs to be able to do
> is to deal with variable length headers, everything else can
> be calculated by userspace(/the user).
>
> So for example if you can match on the IP payload length,
> you *know* the UDP data length is that value - 8.

Well that _is_ what we do:

        case IPPROTO_UDPLITE:
                *length = skb->len - offset - sizeof(struct udphdr);

and then it already returns to

        return (len >= info->min && len <= info->max) ^
               !!(info->flags & XT_LENGTH_INVERT);


> Whats that SCTP thing about?

It only counts the SCTP DATA substreams. In TCP this is not necessary
because all tcp control data is in the tcphdr already, but in
sctp this does not seem to be the case.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux