Re: [PATCH 2/8] [NETFILTER]: Use bool type in struct nf_conntrack_l3proto

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
commit bb84a3dab22636fbf691b913a4ceff836c21ffb4
Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
Date:   Sat Mar 8 15:16:53 2008 +0100

    [NETFILTER]: Use bool type in struct nf_conntrack_l3proto

    Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>

-    int (*pkt_to_tuple)(const struct sk_buff *skb, unsigned int nhoff,
-                struct nf_conntrack_tuple *tuple);
+    bool (*pkt_to_tuple)(const struct sk_buff *skb, unsigned int nhoff,
+                         struct nf_conntrack_tuple *tuple);


This doesn't apply because of whitespace damage:

         * Try to fill in the third arg: nhoff is offset of l3 proto
* hdr. Return true if possible.
^^^^^^^^^^ spaces that are not present in the tree

I even tried the files taken from Maildir/, so its not mailer related.

Besides that it *still* uses spaced for indentation. I didn't
mean you should run it through your own checkpatch.pl version that
doesn't complain about whitespace but through the one contained in
the kernel tree.


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux