On Thursday 2008-04-03 17:00, Patrick McHardy wrote:
ERROR: use tabs not spaces
#32: FILE: include/net/netfilter/nf_conntrack_l4proto.h:48:
+^I unsigned int dataoff);$
<hundreds more>
Jan, applying your patches is getting too much work, I'm
dropping everything I haven't applied yet. Your other patches
also have checkpatch errors, I'll fix those up :|
Some hints for the future to make this easier for both of us:
- submit small batches, split into logical units
This sets me up a bit.. sometimes it's "should have folded these"
(like the const annotation patches that were at the start of
the series), then it's "smaller batches" :-/
- avoid style changes like this, especially when the entire file
uses a consistent style:
-static int icmpv6_pkt_to_tuple(const struct sk_buff *skb,
- unsigned int dataoff,
- struct nf_conntrack_tuple *tuple)
allow me the remark of "consistently odd", as you can see what a
change in indent does when spaces are not used in the right
place. But whatever, yeah.
+static bool
+icmpv6_pkt_to_tuple(const struct sk_buff *skb, unsigned int dataoff,
+ struct nf_conntrack_tuple *tuple)
- run checkpatch
Not before I rip out that incredibly stupid "use tabs" warning.
The warning may be right for users who apparently have not dealt
with patch submitting process a lot, but for longtime contributers
that get their style right the 1st time it's just wrong.
That program has no sense for when spaces are needed.
The style I used and use (tabs=indent, spaces=align - it only makes
sense) was always fine by you, but now it's not because
checkpatch says so?
- don't mix cleanups with real changes
- run sparse with endian checks
- compile test all the code your changing, including CONFIG_COMPAT
Will do.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
