Jan Engelhardt wrote:
Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> --- include/net/netfilter/nf_conntrack_l4proto.h | 13 ++-- net/ipv4/netfilter/nf_conntrack_proto_icmp.c | 25 ++++---- net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c | 27 ++++----- net/netfilter/nf_conntrack_proto_generic.c | 20 +++--- net/netfilter/nf_conntrack_proto_gre.c | 25 ++++---- net/netfilter/nf_conntrack_proto_sctp.c | 33 +++++------ net/netfilter/nf_conntrack_proto_tcp.c | 48 +++++++--------- net/netfilter/nf_conntrack_proto_udp.c | 21 +++---- net/netfilter/nf_conntrack_proto_udplite.c | 22 ++++----
ERROR: use tabs not spaces #13: FILE: include/net/netfilter/nf_conntrack_l4proto.h:29: +^I struct nf_conntrack_tuple *tuple);$ ERROR: use tabs not spaces #21: FILE: include/net/netfilter/nf_conntrack_l4proto.h:35: +^I const struct nf_conntrack_tuple *orig);$ ERROR: use tabs not spaces #32: FILE: include/net/netfilter/nf_conntrack_l4proto.h:48: +^I unsigned int dataoff);$ <hundreds more> Jan, applying your patches is getting too much work, I'm dropping everything I haven't applied yet. Your other patches also have checkpatch errors, I'll fix those up :| Some hints for the future to make this easier for both of us: - submit small batches, split into logical units - don't mix cleanups with real changes - avoid style changes like this, especially when the entire file uses a consistent style:
-static int icmpv6_pkt_to_tuple(const struct sk_buff *skb, - unsigned int dataoff, - struct nf_conntrack_tuple *tuple) +static bool +icmpv6_pkt_to_tuple(const struct sk_buff *skb, unsigned int dataoff, + struct nf_conntrack_tuple *tuple)
- run checkpatch - run sparse with endian checks - compile test all the code your changing, including CONFIG_COMPAT -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
