[NETFILTER 01/02]: nf_conntrack_h323: logical-bitwise & confusion in process_setup()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



commit 3e760ed979f6dbf063ced2117328ffee56620bbd
Author: Roel Kluin <12o3l@xxxxxxxxxx>
Date:   Thu Mar 20 18:34:39 2008 +0100

    [NETFILTER]: nf_conntrack_h323: logical-bitwise & confusion in process_setup()
    
    logical-bitwise & confusion
    
    Signed-off-by: Roel Kluin <12o3l@xxxxxxxxxx>
    Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>

diff --git a/net/netfilter/nf_conntrack_h323_main.c b/net/netfilter/nf_conntrack_h323_main.c
index 6213787..898f192 100644
--- a/net/netfilter/nf_conntrack_h323_main.c
+++ b/net/netfilter/nf_conntrack_h323_main.c
@@ -842,7 +842,7 @@ static int process_setup(struct sk_buff *skb, struct nf_conn *ct,
 
 	set_h225_addr = rcu_dereference(set_h225_addr_hook);
 	if ((setup->options & eSetup_UUIE_destCallSignalAddress) &&
-	    (set_h225_addr) && ct->status && IPS_NAT_MASK &&
+	    (set_h225_addr) && ct->status & IPS_NAT_MASK &&
 	    get_h225_addr(ct, *data, &setup->destCallSignalAddress,
 			  &addr, &port) &&
 	    memcmp(&addr, &ct->tuplehash[!dir].tuple.src.u3, sizeof(addr))) {

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux