Holger Eitzenberger wrote: > comparing your patch with the one I provided in my last patch collection > I can say that your patch is quite larger due to the usage of the > red-black trees in the timer code. The number of timers in ulogd is > depending of your configuration of course, but with my current > configuration (NFLOG, NFCT, SQLITE3) I have currently three timers, wow. > > Note that with your patch you basically remove the possibility for > plugins to have timers which are asynchronous. It's therefore less > flexible for future users. Please, could you tell me why my timer approach is less flexible? > Also note that libraries such as libevent do it quite similar than > provided in my patch. Indeed. This was the intention of my patch, to make ulogd event-driven and so timers synchronous using select() which simplifies the timer infrastructure instead of using SIGALRM. > My patch has the intention of providing a flexible infrastructure for > plugins, which room for future improvements (such as red-black trees if > there are hundreds of timers). Some of my later patches I have > enqueued locally base on those changes, but that's my problem. > > You commented on some of those patches, with a quite positive statement > to my initial post of this patch. Also, Eric gave a GO on all patches > despite the last NFCT patch, which I promised to rework for > compatibility reason and based on your suggestions. I have barely touched NFCT. I'm still waiting for your NFCT patch. > I accept the fact that you apparently like red-black trees and they > definitely have their use-cases, but looking at typical ulogd > configurations and numbers of timers in ulogd I can say that red-black > trees just for timer usage seem to me like overkill. We can easily implement list-based timers using the same API. You only have to use the current timer API in your patches. > Since you are in the habit of favoring your own patches against the ones > I provide, even without giving a chance to modify my patch, I simply > consider doing a fork of ulogd. You still have the chance to modify your patches. I'm not disregarding your work. > Otherwise I'll loose many of the work I've enqueued locally. I have kept lots of patches locally in my whole life that I had rework lots of times to get them into mainline... -- "Los honestos son inadaptados sociales" -- Les Luthiers - To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
