From: Yasuyuki KOZAKAI <yasuyuki.kozakai@xxxxxxxxxxxxx>
Date: Fri, 25 Jan 2008 10:24:10 +0900 (JST)
> From: Patrick McHardy <kaber@xxxxxxxxx>
> Date: Thu, 24 Jan 2008 19:45:42 +0100
>
> > Stephen Hemminger wrote:
> >
> > > +#ifdef notused
> > > int nf_ct_frag6_kfree_frags(struct sk_buff *skb)
> > > {
> > > struct sk_buff *s, *s2;
> > > @@ -694,6 +696,7 @@ int nf_ct_frag6_kfree_frags(struct sk_bu
> > >
> > > return 0;
> > > }
> > > +#endif
> >
> > I'm wondering whether this is correct. I'm on the way out the
> > door though, I'll look into it later. Thanks Stephen.
>
> I'll check it, too. At least linux 2.6.15 (which is the first release
> for nf_contrack) does not use the function. I try to recall the reason.
I agree to remove the function.
I seemed to forget to remove it when implementing nf_conntrack based on
ip6_conntrack. The later used it to free the reassembled skb packet the
original fragments on fail of tracking. But the function became unnecessary
as result of changing data structure so that packets could be reassembled
at new hook - NF_IP6_PRI_CONNTRACK_DEFRAG.
Regards,
-- Yasuyuki Kozakai
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
