Re: [LIBNL 07/09]: Split up nfnetlink_log into log and msg objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Philip Craig wrote:
Patrick McHardy wrote:
commit c566db4405200994482d36fac45089aba4e2360a
Author: Patrick McHardy <kaber@xxxxxxxxx>
Date:   Fri Jan 18 17:52:41 2008 +0100

    [LIBNL]: Split up nfnetlink_log into log and msg objects
Split the nfnetlink_log code into two seperate objects, "netfilter/log"
    to represent logging instances and "netfilter/log_msg" to represent
    log messages. Also perform some function name unification for consistency
    with other libnl object types, mainly renaming nfnl_log_build_*_msg
    to nfnl_log_build_*_request.
This changes the API in an incompatible way, but since this feature is
    new and the libnl netfilter headers haven't been installed so far,
    there shouldn't be any users affected by this.
Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>

Definitely an improvement, thanks. The pf bind/unbind are still handled
differently, but I guess they are too simple to warrant it and will
never get more attributes.

Yes, I kept those seperated from the log object because we can
subscribe to multiple families and this really didn't fit the
object model very well. I still hope to get rid of these within
the kernel some day.

I hadn't noticed the missing headers because my cross compile
environment has its own custom install target.

I was happy to discover it since this means we can change the
API without annoying users :)
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux