The patch titled
Subject: include/linux/spinlock.h: add a kerneldoc comment to spin_is_locked() that discourages its use
has been added to the -mm tree. Its filename is
include-linux-spinlockh-add-a-kerneldoc-comment-to-spin_is_locked-that-discourages-its-use.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
Subject: include/linux/spinlock.h: add a kerneldoc comment to spin_is_locked() that discourages its use
Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/spinlock.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff -puN include/linux/spinlock.h~include-linux-spinlockh-add-a-kerneldoc-comment-to-spin_is_locked-that-discourages-its-use include/linux/spinlock.h
--- a/include/linux/spinlock.h~include-linux-spinlockh-add-a-kerneldoc-comment-to-spin_is_locked-that-discourages-its-use
+++ a/include/linux/spinlock.h
@@ -360,6 +360,15 @@ static inline void spin_unlock_wait(spin
raw_spin_unlock_wait(&lock->rlock);
}
+/**
+ * spin_is_locked() - Check if a spinlock is being held.
+ * @lock: Lock to check.
+ *
+ * This function should normally not be used. Especially using it in
+ * WARN and BUG_ONs is usually incorrect or redundant.
+ * If you want to check if a lock is held in a function
+ * use lockdep_assert_held(). A lot of other usages are racy.
+ */
static inline int spin_is_locked(spinlock_t *lock)
{
return raw_spin_is_locked(&lock->rlock);
_
Subject: Subject: include/linux/spinlock.h: add a kerneldoc comment to spin_is_locked() that discourages its use
Patches currently in -mm which might be from ak@xxxxxxxxxxxxxxx are
origin.patch
brlocks-lglocks-cleanups.patch
block-use-lockdep_assert_held-for-queue-locking.patch
sgi-xp-use-lockdep_assert_held.patch
drivers-scsi-aha152xc-remove-broken-usage-of-spin_is_locked.patch
xfs-fix-lock-assert-on-up.patch
mm-huge_memoryc-use-lockdep_assert_held.patch
futex-use-lockdep_assert_held-for-lock-checking.patch
drivers-net-irda-sir_devc-remove-spin_is_locked.patch
drivers-net-ethernet-smsc-smsc911xh-use-lockdep_assert_held-instead-of-home-grown-buggy-construct.patch
spinlockstxt-add-a-discussion-on-why-spin_is_locked-is-bad.patch
include-linux-spinlockh-add-a-kerneldoc-comment-to-spin_is_locked-that-discourages-its-use.patch
checkpatch-check-for-spin_is_locked.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
