The patch titled Subject: drivers/net/irda/sir_dev.c: remove spin_is_locked() has been added to the -mm tree. Its filename is drivers-net-irda-sir_devc-remove-spin_is_locked.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Andi Kleen <ak@xxxxxxxxxxxxxxx> Subject: drivers/net/irda/sir_dev.c: remove spin_is_locked() It's hard to imagine how this spin_is_locked() debugging check is not totally racy. Remove it. Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx> Cc: Samuel Ortiz <samuel@xxxxxxxxxx> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/net/irda/sir_dev.c | 5 ----- 1 file changed, 5 deletions(-) diff -puN drivers/net/irda/sir_dev.c~drivers-net-irda-sir_devc-remove-spin_is_locked drivers/net/irda/sir_dev.c --- a/drivers/net/irda/sir_dev.c~drivers-net-irda-sir_devc-remove-spin_is_locked +++ a/drivers/net/irda/sir_dev.c @@ -632,11 +632,6 @@ static netdev_tx_t sirdev_hard_xmit(stru /* Init tx buffer*/ dev->tx_buff.data = dev->tx_buff.head; - /* Check problems */ - if(spin_is_locked(&dev->tx_lock)) { - IRDA_DEBUG(3, "%s(), write not completed\n", __func__); - } - /* serialize with write completion */ spin_lock_irqsave(&dev->tx_lock, flags); _ Subject: Subject: drivers/net/irda/sir_dev.c: remove spin_is_locked() Patches currently in -mm which might be from ak@xxxxxxxxxxxxxxx are origin.patch brlocks-lglocks-cleanups.patch block-use-lockdep_assert_held-for-queue-locking.patch sgi-xp-use-lockdep_assert_held.patch drivers-scsi-aha152xc-remove-broken-usage-of-spin_is_locked.patch xfs-fix-lock-assert-on-up.patch mm-huge_memoryc-use-lockdep_assert_held.patch futex-use-lockdep_assert_held-for-lock-checking.patch drivers-net-irda-sir_devc-remove-spin_is_locked.patch drivers-net-ethernet-smsc-smsc911xh-use-lockdep_assert_held-instead-of-home-grown-buggy-construct.patch spinlockstxt-add-a-discussion-on-why-spin_is_locked-is-bad.patch include-linux-spinlockh-add-a-kerneldoc-comment-to-spin_is_locked-that-discourages-its-use.patch checkpatch-check-for-spin_is_locked.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html