The patch titled kernel/configs.c: include MODULE_*() when CONFIG_IKCONFIG_PROC=n has been added to the -mm tree. Its filename is kernel-configsc-include-module_-when-config_ikconfig_proc=n.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: kernel/configs.c: include MODULE_*() when CONFIG_IKCONFIG_PROC=n From: Stephen Boyd <bebarino@xxxxxxxxx> If CONFIG_IKCONFIG=m but CONFIG_IKCONFIG_PROC=n we get a module that has no MODULE_LICENSE definition. Move the MODULE_*() definitions outside the CONFIG_IKCONFIG_PROC #ifdef to prevent this configuration from tainting the kernel. Signed-off-by: Stephen Boyd <bebarino@xxxxxxxxx> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx> Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/configs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN kernel/configs.c~kernel-configsc-include-module_-when-config_ikconfig_proc=n kernel/configs.c --- a/kernel/configs.c~kernel-configsc-include-module_-when-config_ikconfig_proc=n +++ a/kernel/configs.c @@ -92,8 +92,8 @@ static void __exit ikconfig_cleanup(void module_init(ikconfig_init); module_exit(ikconfig_cleanup); +#endif /* CONFIG_IKCONFIG_PROC */ + MODULE_LICENSE("GPL"); MODULE_AUTHOR("Randy Dunlap"); MODULE_DESCRIPTION("Echo the kernel .config file used to build the kernel"); - -#endif /* CONFIG_IKCONFIG_PROC */ _ Patches currently in -mm which might be from bebarino@xxxxxxxxx are kernel-configsc-include-module_-when-config_ikconfig_proc=n.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html