The patch titled iosched: remove redundant sprintf has been added to the -mm tree. Its filename is iosched-remove-redundant-sprintf.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: iosched: remove redundant sprintf From: Kees Cook <kees.cook@xxxxxxxxxxxxx> After the anticipatory scheduler was dropped, there was no need to special-case the request_module string. As such, drop the redundant sprintf and stack variable. Signed-off-by: Kees Cook <kees.cook@xxxxxxxxxxxxx> Cc: Jens Axboe <axboe@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- block/elevator.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff -puN block/elevator.c~iosched-remove-redundant-sprintf block/elevator.c --- a/block/elevator.c~iosched-remove-redundant-sprintf +++ a/block/elevator.c @@ -155,13 +155,8 @@ static struct elevator_type *elevator_ge e = elevator_find(name); if (!e) { - char elv[ELV_NAME_MAX + strlen("-iosched")]; - spin_unlock(&elv_list_lock); - - snprintf(elv, sizeof(elv), "%s-iosched", name); - - request_module("%s", elv); + request_module("%s-iosched", name); spin_lock(&elv_list_lock); e = elevator_find(name); } _ Patches currently in -mm which might be from kees.cook@xxxxxxxxxxxxx are linux-next.patch net-convert-%p-usage-to-%pk.patch iosched-remove-redundant-sprintf.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html