+ drivers-char-rawc-remove-call-to-kobject_put.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     drivers/char/raw.c: remove call to kobject_put().
has been added to the -mm tree.  Its filename is
     drivers-char-rawc-remove-call-to-kobject_put.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: drivers/char/raw.c: remove call to kobject_put().
From: "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx>

If cdev_add() fails, there is no justification for subsequently
calling kobject_put().

Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/char/raw.c |    1 -
 1 file changed, 1 deletion(-)

diff -puN drivers/char/raw.c~drivers-char-rawc-remove-call-to-kobject_put drivers/char/raw.c
--- a/drivers/char/raw.c~drivers-char-rawc-remove-call-to-kobject_put
+++ a/drivers/char/raw.c
@@ -319,7 +319,6 @@ static int __init raw_init(void)
 	cdev_init(&raw_cdev, &raw_fops);
 	ret = cdev_add(&raw_cdev, dev, MAX_RAW_MINORS);
 	if (ret) {
-		kobject_put(&raw_cdev.kobj);
 		goto error_region;
 	}
 
_

Patches currently in -mm which might be from rpjday@xxxxxxxxxxxxxx are

linux-next.patch
drivers-char-rawc-remove-call-to-kobject_put.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux