The patch titled drivers/message/fusion: Move a dereference below a NULL test has been removed from the -mm tree. Its filename was drivers-message-fusion-move-a-dereference-below-a-null-test.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/message/fusion: Move a dereference below a NULL test From: Julia Lawall <julia@xxxxxxx> If the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/). // <smpl> @disable is_null@ identifier f; expression E; identifier fld; statement S; @@ + if (E == NULL) S f(...,E->fld,...); - if (E == NULL) S @@ identifier f; expression E; identifier fld; statement S; @@ + if (!E) S f(...,E->fld,...); - if (!E) S // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> Acked-by: "Prakash, Sathya" <Sathya.Prakash@xxxxxxx> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/message/fusion/mptctl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff -puN drivers/message/fusion/mptctl.c~drivers-message-fusion-move-a-dereference-below-a-null-test drivers/message/fusion/mptctl.c --- a/drivers/message/fusion/mptctl.c~drivers-message-fusion-move-a-dereference-below-a-null-test +++ a/drivers/message/fusion/mptctl.c @@ -308,10 +308,11 @@ static void mptctl_timeout_expired (MPT_ { int rc = 1; - dctlprintk(ioctl->ioc, printk(MYIOC_s_DEBUG_FMT ": Timeout Expired! Host %d\n", - ioctl->ioc->name, ioctl->ioc->id)); if (ioctl == NULL) return; + dctlprintk(ioctl->ioc, + printk(MYIOC_s_DEBUG_FMT ": Timeout Expired! Host %d\n", + ioctl->ioc->name, ioctl->ioc->id)); ioctl->wait_done = 0; if (ioctl->reset & MPTCTL_RESET_OK) _ Patches currently in -mm which might be from julia@xxxxxxx are origin.patch linux-next.patch arch-avr32-eliminate-null-test-and-memset-after-alloc_bootmem.patch powerpc-powermac-add-missing-of_node_put.patch net-tipc-bcasth-use-array_size.patch net-bridge-netfilter-move-a-dereference-below-a-null-test.patch drivers-isdn-hardware-misdn-move-a-dereference-below-a-null-test.patch drivers-net-hamradio-6packc-move-a-dereference-below-a-null-test.patch drivers-net-wireless-libertas-move-a-dereference-below-a-null-test.patch mm-page_allocc-eliminate-null-test-and-memset-after-alloc_bootmem.patch drivers-macintosh-add-missing-of_node_put-in-therm_adt746xc.patch drivers-spi-move-a-dereference-below-a-null-test.patch drivers-rtc-correct-an-error-test.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html