The patch titled drivers/scsi: move a dereference below a NULL test has been removed from the -mm tree. Its filename was drivers-scsi-move-a-dereference-below-a-null-test.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/scsi: move a dereference below a NULL test From: Julia Lawall <julia@xxxxxxx> In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> Acked-by: James Smart <James.Smart@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/scsi/lpfc/lpfc_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN drivers/scsi/lpfc/lpfc_init.c~drivers-scsi-move-a-dereference-below-a-null-test drivers/scsi/lpfc/lpfc_init.c --- a/drivers/scsi/lpfc/lpfc_init.c~drivers-scsi-move-a-dereference-below-a-null-test +++ a/drivers/scsi/lpfc/lpfc_init.c @@ -1736,12 +1736,13 @@ lpfc_block_mgmt_io(struct lpfc_hba * phb int lpfc_online(struct lpfc_hba *phba) { - struct lpfc_vport *vport = phba->pport; + struct lpfc_vport *vport; struct lpfc_vport **vports; int i; if (!phba) return 0; + vport = phba->pport; if (!(vport->fc_flag & FC_OFFLINE_MODE)) return 0; _ Patches currently in -mm which might be from julia@xxxxxxx are origin.patch linux-next.patch arch-avr32-eliminate-null-test-and-memset-after-alloc_bootmem.patch powerpc-powermac-add-missing-of_node_put.patch net-tipc-bcasth-use-array_size.patch net-bridge-netfilter-move-a-dereference-below-a-null-test.patch drivers-isdn-hardware-misdn-move-a-dereference-below-a-null-test.patch drivers-net-hamradio-6packc-move-a-dereference-below-a-null-test.patch drivers-net-wireless-libertas-move-a-dereference-below-a-null-test.patch mm-page_allocc-eliminate-null-test-and-memset-after-alloc_bootmem.patch drivers-macintosh-add-missing-of_node_put-in-therm_adt746xc.patch drivers-spi-move-a-dereference-below-a-null-test.patch drivers-rtc-correct-an-error-test.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html