The patch titled
sysfs: fix off-by-one error in fill_read_buffer() (update)
has been added to the -mm tree. Its filename is
sysfs-fix-off-by-one-error-in-fill_read_buffer.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: sysfs: fix off-by-one error in fill_read_buffer() (update)
From: Miao Xie <miaox@xxxxxxxxxxxxxx>
Add a comment requested by Tejun.
Signed-off-by: Miao Xie <miaox@xxxxxxxxxxxxxx>
Acked-by: Tejun Heo <htejun@xxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/sysfs/file.c | 4 ++++
1 file changed, 4 insertions(+)
diff -puN fs/sysfs/file.c~sysfs-fix-off-by-one-error-in-fill_read_buffer fs/sysfs/file.c
--- a/fs/sysfs/file.c~sysfs-fix-off-by-one-error-in-fill_read_buffer
+++ a/fs/sysfs/file.c
@@ -90,6 +90,10 @@ static int fill_read_buffer(struct dentr
sysfs_put_active_two(attr_sd);
+ /*
+ * The code works fine with PAGE_SIZE return but it's likely to
+ * indicate truncated result or overflow in normal use cases.
+ */
BUG_ON(count >= (ssize_t)PAGE_SIZE);
if (count >= 0) {
buffer->needs_read_fill = 0;
_
Patches currently in -mm which might be from miaox@xxxxxxxxxxxxxx are
sysfs-fix-off-by-one-error-in-fill_read_buffer.patch
time-fix-sysfs_show_availablecurrent_clocksources-buffer-overflow-problem.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
