- uninitialised-variable-in-arm-ixp4xx-clockevents-code.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     uninitialised variable in ARM/ixp4xx clockevents code
has been removed from the -mm tree.  Its filename was
     uninitialised-variable-in-arm-ixp4xx-clockevents-code.patch

This patch was dropped because an updated version will be merged

------------------------------------------------------
Subject: uninitialised variable in ARM/ixp4xx clockevents code
From: Mikael Pettersson <mikpe@xxxxxxxx>

Compiling kernel 2.6.23 for an ARM/ixp4xx machine results in:

arch/arm/mach-ixp4xx/common.c: In function 'ixp4xx_set_mode':
arch/arm/mach-ixp4xx/common.c:445: warning: 'opts' may be used uninitialized in this function

The warning is valid: if ixp4xx_set_mode() is called with mode
CLOCK_EVT_MODE_RESUME, then 'opts' will be uninitialised at the
'*IXP4XX_OSRT1 = osrt | opts;' statement.

Initialising opts to zero in this case may not be correct, but
at least it's better than writing random junk to the hardware.

Signed-off-by: Mikael Pettersson <mikpe@xxxxxxxx>
Cc: Deepak Saxena <dsaxena@xxxxxxxxxxx>
Cc: Russell King <rmk@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 arch/arm/mach-ixp4xx/common.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN arch/arm/mach-ixp4xx/common.c~uninitialised-variable-in-arm-ixp4xx-clockevents-code arch/arm/mach-ixp4xx/common.c
--- a/arch/arm/mach-ixp4xx/common.c~uninitialised-variable-in-arm-ixp4xx-clockevents-code
+++ a/arch/arm/mach-ixp4xx/common.c
@@ -460,6 +460,7 @@ static void ixp4xx_set_mode(enum clock_e
 		osrt = opts = 0;
 		break;
 	case CLOCK_EVT_MODE_RESUME:
+		opts = 0;
 		break;
 	}
 
_

Patches currently in -mm which might be from mikpe@xxxxxxxx are

uninitialised-variable-in-arm-ixp4xx-clockevents-code.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux