The patch titled
r/o bind mounts: remove IS_RDONLY() from permission()
has been removed from the -mm tree. Its filename was
r-o-bind-mounts-remove-is_rdonly-from-permission.patch
This patch was dropped because it had testing failures
------------------------------------------------------
Subject: r/o bind mounts: remove IS_RDONLY() from permission()
From: Dave Hansen <hansendc@xxxxxxxxxx>
All callers of permission() should be updated now to use the
mnt_want/drop_write() functions. It is now safe to remove this check.
We'll put a BUG_ON() in here for now just in case some user manages to get in
here by code that gets added in the future but forgets its
mnt_want/drop_write() pair.
Signed-off-by: Dave Hansen <haveblue@xxxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: Miklos Szeredi <miklos@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/namei.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff -puN fs/namei.c~r-o-bind-mounts-remove-is_rdonly-from-permission fs/namei.c
--- a/fs/namei.c~r-o-bind-mounts-remove-is_rdonly-from-permission
+++ a/fs/namei.c
@@ -231,13 +231,12 @@ int permission(struct inode *inode, int
int retval, submask;
if (mask & MAY_WRITE) {
-
/*
- * Nobody gets write access to a read-only fs.
+ * Nobody should have been able to get here with
+ * a r/o filesystem.
*/
- if (IS_RDONLY(inode) &&
- (S_ISREG(mode) || S_ISDIR(mode) || S_ISLNK(mode)))
- return -EROFS;
+ BUG_ON(IS_RDONLY(inode) &&
+ (S_ISREG(mode) || S_ISDIR(mode) || S_ISLNK(mode)));
/*
* Nobody gets write access to an immutable file.
_
Patches currently in -mm which might be from hansendc@xxxxxxxxxx are
r-o-bind-mounts-remove-is_rdonly-from-permission.patch
r-o-bind-mounts-reiser4-remove-is_rdonly-checks.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
