Re: + minmaxh-simplify-the-variants-of-clamp.patch added to mm-nonmm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lorenzo,

On 29.11.24 13:14, Lorenzo Stoakes wrote:
On Fri, Nov 29, 2024 at 12:10:19PM +0000, David Laight wrote:
From: Lorenzo Stoakes
Sent: 29 November 2024 12:06

On Fri, Nov 29, 2024 at 11:56:01AM +0000, David Laight wrote:
From: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
Sent: 29 November 2024 11:46

On Fri, Nov 29, 2024 at 03:11:43AM -0800, Andrew Morton wrote:

The patch titled
      Subject: minmax.h: simplify the variants of clamp()
has been added to the -mm mm-nonmm-unstable branch.  Its filename is
      minmaxh-simplify-the-variants-of-clamp.patch

Hmm, this was generating kernel test bot reports, should we be taking it without
that being fixed?

That is reported for W=1 builds and is correctly reporting some very
badly broken code - that has always been broken.

Probably also only affects allmodconfig builds because the code in
question is unlikely to be included.

Ah fair play, you are poking around in some creaky, cobweb filled bits of
the kernel so perhaps not a surprise...

We should probably try and sort out the W=1 stuff though! And by 'we' I
mean you obviously ;)

Not me, Jakob is trying to fix the magnetometer/yamaha-yas530.c driver.
But I keep on pointing out just how broken the code was.
So there should be a patch to it (that needs backporting) soon.

Presumably that somehow interacts with this clamp code that he's also
addressing you mean? As that's something of a specific driver (I have no
idea even what a magnetometer is...)

I'm working on cleaning up that part in drivers/iio/magnetometer/yamaha-yas530.c. v1: https://lore.kernel.org/linux-iio/20241126234021.19749-1-jahau@xxxxxxxxxxxxxx/T/#u v2: https://lore.kernel.org/linux-iio/11609b2243c295d65ab4d47e78c239d61ad6be75.1732914810.git.jahau@xxxxxxxxxxxxxx/T/#u

In general your series seems mostly to be various reasonable cleanups (at a
glance) so think we're all good to at least have this in 6.14 unstable
anyway, to be clear.

Kind regards,
Jakob





[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux