On Fri, Nov 29, 2024 at 12:10:19PM +0000, David Laight wrote: > From: Lorenzo Stoakes > > Sent: 29 November 2024 12:06 > > > > On Fri, Nov 29, 2024 at 11:56:01AM +0000, David Laight wrote: > > > From: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> > > > > Sent: 29 November 2024 11:46 > > > > > > > > On Fri, Nov 29, 2024 at 03:11:43AM -0800, Andrew Morton wrote: > > > > > > > > > > The patch titled > > > > > Subject: minmax.h: simplify the variants of clamp() > > > > > has been added to the -mm mm-nonmm-unstable branch. Its filename is > > > > > minmaxh-simplify-the-variants-of-clamp.patch > > > > > > > > Hmm, this was generating kernel test bot reports, should we be taking it without > > > > that being fixed? > > > > > > That is reported for W=1 builds and is correctly reporting some very > > > badly broken code - that has always been broken. > > > > > > Probably also only affects allmodconfig builds because the code in > > > question is unlikely to be included. > > > > Ah fair play, you are poking around in some creaky, cobweb filled bits of > > the kernel so perhaps not a surprise... > > > > We should probably try and sort out the W=1 stuff though! And by 'we' I > > mean you obviously ;) > > Not me, Jakob is trying to fix the magnetometer/yamaha-yas530.c driver. > But I keep on pointing out just how broken the code was. > So there should be a patch to it (that needs backporting) soon. Presumably that somehow interacts with this clamp code that he's also addressing you mean? As that's something of a specific driver (I have no idea even what a magnetometer is...) In general your series seems mostly to be various reasonable cleanups (at a glance) so think we're all good to at least have this in 6.14 unstable anyway, to be clear. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) >
