The quilt patch titled
Subject: KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko
has been removed from the -mm tree. Its filename was
kunit-add-missing-module_description-macros-for-lib-test_ko.patch
This patch was dropped because it was merged into the mm-nonmm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
Subject: KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko
Date: Wed, 19 Jun 2024 13:59:15 -0700
make allmodconfig && make W=1 C=1 reports for lib/test_*.ko:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hexdump.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_dhry.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_firmware.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sysctl.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hash.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ida.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_list_sort.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_min_heap.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_module.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sort.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_keys.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_key_base.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_memcat_p.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_blackhole_dev.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_meminit.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_free_pages.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_kprobes.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ref_tracker.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bits.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
Link: https://lkml.kernel.org/r/20240619-md-lib-test-v2-1-301e30eeba1e@xxxxxxxxxxx
Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
Reviewed-by: Kees Cook <kees@xxxxxxxxxx>
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@xxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Cc: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
Cc: "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/dhry_run.c | 1 +
lib/test-kstrtox.c | 1 +
lib/test_bits.c | 1 +
lib/test_blackhole_dev.c | 1 +
lib/test_firmware.c | 1 +
lib/test_free_pages.c | 1 +
lib/test_hash.c | 1 +
lib/test_hexdump.c | 1 +
lib/test_ida.c | 1 +
lib/test_kprobes.c | 3 ++-
lib/test_list_sort.c | 1 +
lib/test_memcat_p.c | 1 +
lib/test_meminit.c | 1 +
lib/test_min_heap.c | 1 +
lib/test_module.c | 1 +
lib/test_ref_tracker.c | 3 ++-
lib/test_sort.c | 1 +
lib/test_static_key_base.c | 1 +
lib/test_static_keys.c | 1 +
lib/test_sysctl.c | 1 +
20 files changed, 22 insertions(+), 2 deletions(-)
--- a/lib/dhry_run.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/dhry_run.c
@@ -83,4 +83,5 @@ static int __init dhry_init(void)
module_init(dhry_init);
MODULE_AUTHOR("Geert Uytterhoeven <geert+renesas@xxxxxxxxx>");
+MODULE_DESCRIPTION("Dhrystone benchmark test module");
MODULE_LICENSE("GPL");
--- a/lib/test_bits.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_bits.c
@@ -72,4 +72,5 @@ static struct kunit_suite bits_test_suit
};
kunit_test_suite(bits_test_suite);
+MODULE_DESCRIPTION("Test cases for functions and macros in bits.h");
MODULE_LICENSE("GPL");
--- a/lib/test_blackhole_dev.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_blackhole_dev.c
@@ -96,4 +96,5 @@ module_init(test_blackholedev_init);
module_exit(test_blackholedev_exit);
MODULE_AUTHOR("Mahesh Bandewar <maheshb@xxxxxxxxxx>");
+MODULE_DESCRIPTION("module test of the blackhole_dev");
MODULE_LICENSE("GPL");
--- a/lib/test_firmware.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_firmware.c
@@ -1567,4 +1567,5 @@ static void __exit test_firmware_exit(vo
module_exit(test_firmware_exit);
MODULE_AUTHOR("Kees Cook <keescook@xxxxxxxxxxxx>");
+MODULE_DESCRIPTION("interface to trigger and test firmware loading");
MODULE_LICENSE("GPL");
--- a/lib/test_free_pages.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_free_pages.c
@@ -44,4 +44,5 @@ static void m_ex(void)
module_init(m_in);
module_exit(m_ex);
MODULE_AUTHOR("Matthew Wilcox <willy@xxxxxxxxxxxxx>");
+MODULE_DESCRIPTION("Check that free_pages() doesn't leak memory");
MODULE_LICENSE("GPL");
--- a/lib/test_hash.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_hash.c
@@ -235,4 +235,5 @@ static struct kunit_suite hash_test_suit
kunit_test_suite(hash_test_suite);
+MODULE_DESCRIPTION("Test cases for <linux/hash.h> and <linux/stringhash.h>");
MODULE_LICENSE("GPL");
--- a/lib/test_hexdump.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_hexdump.c
@@ -253,4 +253,5 @@ static void __exit test_hexdump_exit(voi
module_exit(test_hexdump_exit);
MODULE_AUTHOR("Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>");
+MODULE_DESCRIPTION("Test cases for lib/hexdump.c module");
MODULE_LICENSE("Dual BSD/GPL");
--- a/lib/test_ida.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_ida.c
@@ -214,4 +214,5 @@ static void ida_exit(void)
module_init(ida_checks);
module_exit(ida_exit);
MODULE_AUTHOR("Matthew Wilcox <willy@xxxxxxxxxxxxx>");
+MODULE_DESCRIPTION("Test the IDA API");
MODULE_LICENSE("GPL");
--- a/lib/test_kprobes.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_kprobes.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
- * test_kprobes.c - simple sanity test for *probes
+ * test_kprobes.c - simple sanity test for k*probes
*
* Copyright IBM Corp. 2008
*/
@@ -400,4 +400,5 @@ static struct kunit_suite kprobes_test_s
kunit_test_suites(&kprobes_test_suite);
+MODULE_DESCRIPTION("simple sanity test for k*probes");
MODULE_LICENSE("GPL");
--- a/lib/test-kstrtox.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test-kstrtox.c
@@ -732,4 +732,5 @@ static int __init test_kstrtox_init(void
return -EINVAL;
}
module_init(test_kstrtox_init);
+MODULE_DESCRIPTION("Module test for kstrto*() APIs");
MODULE_LICENSE("Dual BSD/GPL");
--- a/lib/test_list_sort.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_list_sort.c
@@ -119,4 +119,5 @@ static struct kunit_suite list_sort_suit
kunit_test_suites(&list_sort_suite);
+MODULE_DESCRIPTION("list_sort() KUnit test suite");
MODULE_LICENSE("GPL");
--- a/lib/test_memcat_p.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_memcat_p.c
@@ -112,4 +112,5 @@ static void __exit test_memcat_p_exit(vo
module_init(test_memcat_p_init);
module_exit(test_memcat_p_exit);
+MODULE_DESCRIPTION("Test cases for memcat_p() in lib/memcat_p.c");
MODULE_LICENSE("GPL");
--- a/lib/test_meminit.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_meminit.c
@@ -436,4 +436,5 @@ static int __init test_meminit_init(void
}
module_init(test_meminit_init);
+MODULE_DESCRIPTION("Test cases for SL[AOU]B/page initialization at alloc/free time");
MODULE_LICENSE("GPL");
--- a/lib/test_min_heap.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_min_heap.c
@@ -226,4 +226,5 @@ static void __exit test_min_heap_exit(vo
}
module_exit(test_min_heap_exit);
+MODULE_DESCRIPTION("Test cases for the min max heap");
MODULE_LICENSE("GPL");
--- a/lib/test_module.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_module.c
@@ -31,4 +31,5 @@ static void __exit test_module_exit(void
module_exit(test_module_exit);
MODULE_AUTHOR("Kees Cook <keescook@xxxxxxxxxxxx>");
+MODULE_DESCRIPTION("module loading subsystem test module");
MODULE_LICENSE("GPL");
--- a/lib/test_ref_tracker.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_ref_tracker.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * Referrence tracker self test.
+ * Reference tracker self test.
*
* Copyright (c) 2021 Eric Dumazet <edumazet@xxxxxxxxxx>
*/
@@ -112,4 +112,5 @@ static void __exit test_ref_tracker_exit
module_init(test_ref_tracker_init);
module_exit(test_ref_tracker_exit);
+MODULE_DESCRIPTION("Reference tracker self test");
MODULE_LICENSE("GPL v2");
--- a/lib/test_sort.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_sort.c
@@ -57,4 +57,5 @@ static struct kunit_suite sort_test_suit
kunit_test_suites(&sort_test_suite);
+MODULE_DESCRIPTION("sort() KUnit test suite");
MODULE_LICENSE("GPL");
--- a/lib/test_static_key_base.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_static_key_base.c
@@ -57,4 +57,5 @@ module_init(test_static_key_base_init);
module_exit(test_static_key_base_exit);
MODULE_AUTHOR("Jason Baron <jbaron@xxxxxxxxxx>");
+MODULE_DESCRIPTION("Kernel module to support testing static keys");
MODULE_LICENSE("GPL");
--- a/lib/test_static_keys.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_static_keys.c
@@ -236,4 +236,5 @@ module_init(test_static_key_init);
module_exit(test_static_key_exit);
MODULE_AUTHOR("Jason Baron <jbaron@xxxxxxxxxx>");
+MODULE_DESCRIPTION("Kernel module for testing static keys");
MODULE_LICENSE("GPL");
--- a/lib/test_sysctl.c~kunit-add-missing-module_description-macros-for-lib-test_ko
+++ a/lib/test_sysctl.c
@@ -280,4 +280,5 @@ static void __exit test_sysctl_exit(void
module_exit(test_sysctl_exit);
MODULE_AUTHOR("Luis R. Rodriguez <mcgrof@xxxxxxxxxx>");
+MODULE_DESCRIPTION("proc sysctl test driver");
MODULE_LICENSE("GPL");
_
Patches currently in -mm which might be from quic_jjohnson@xxxxxxxxxxx are
kfifo-add-missing-module_description-macros.patch
resource-add-missing-module_description.patch
selftests-fpu-add-missing-module_description-macro.patch
