On Fri, Oct 6, 2023 at 2:53 AM Ryan Roberts <ryan.roberts@xxxxxxx> wrote: > > On 05/10/2023 20:23, Yu Zhao wrote: > > On Thu, Oct 5, 2023 at 2:12 AM David Hildenbrand <david@xxxxxxxxxx> wrote: > >> > >> On 29.09.23 21:08, Andrew Morton wrote: > >>> > >>> The patch titled > >>> Subject: mm: non-pmd-mappable, large folios for folio_add_new_anon_rmap() > >>> has been added to the -mm mm-unstable branch. Its filename is > >>> mm-non-pmd-mappable-large-folios-for-folio_add_new_anon_rmap.patch > >>> > >> > >> Andrew, please don't move these patches to stable before we have a > >> couple of acks from people involved in the discussions. > >> > >> I'm confident that we'll get them into 6.8. > > > > I am not :) > > I don't find that comment particularly helpful; Are you implying a NAK? If so, > some rationale and actionable suggestions would help. >From my POV, there have been some random changes between each version of your patchset: 1. v3 *introduced* a boot parameter `flexthp_unhinted_max`, which *disappeared* in later versions. 2. v4 *introduced* a random constant ANON_FOLIO_MAX_ORDER_UNHINTED, which *disappeared* in v6. 3. v5 is really close to what I think can be merged -- my only objection is to ANON_FOLIO_MAX_ORDER_UNHINTED, I've never heard *a good reason* why that random constant should sit in core mm. 4. v6 *introduced* a sysfs ABI -- we had a couple of alignment meetings about how it might look but there was *never a consensus*. FWICT, you haven't made up your mind. So I'm not convinced this series is close to being ready to introduce an ABI. This is NOT a NAK, just a ton of concerns with your current approach. And I'm not sure how I could be more clear on how we can move forward progress [1][2][3]. Some suggestions would also help. [1] v3 https://lore.kernel.org/linux-mm/CAOUHufaDfJwF_-zb6zV5COG-KaaGcSyrNmbaEzaWz2UjcGGgHQ@xxxxxxxxxxxxxx/ [2] v4 https://lore.kernel.org/linux-mm/CAOUHufackQzy+yXOzaej+G6DNYK-k9GAUHAK6Vq79BFHr7KwAQ@xxxxxxxxxxxxxx/ [3] v5 https://lore.kernel.org/linux-mm/CAOUHufbUGwc2XvZOBmTCzMsOHxP-eLB60EdysKYzrkRMScOyMg@xxxxxxxxxxxxxx/
