On Mon, Sep 11, 2023 at 02:59:56PM -0700, Andrew Morton wrote: > On Tue, 12 Sep 2023 00:47:43 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: ... > > > -/* > > > * Do not check the array parameter using __must_be_array(). > > > * In the following legit use-case where the "array" passed is a simple pointer, > > > * __must_be_array() will return a failure. > > > > A side note: If you look at the original email and patch you will see a subtle > > difference that makes patch better looking. It's because I started using > > --patience when formatting them. Perhaps you can enable it in your scripts. > > Interesting, thanks. > > I use plain old diff :(. A while back I had everything working (I > thought) using `git diff' instead but found that it was producing diffs that > gave git-quiltimport a heart attack. Ran out of time, didn't debug, > disabled it. I'll revisit at some point. Ah, I see. I don't know good implementation of patience diff outside of the Git, not sure then if you can enable it easily. -- With Best Regards, Andy Shevchenko