On (22/11/15 14:58), Minchan Kim wrote:
> > --- a/drivers/block/zram/zram_drv.c~zram-introduce-recompress-sysfs-knob-fix-2
> > +++ a/drivers/block/zram/zram_drv.c
> > @@ -1689,6 +1689,7 @@ static int zram_recompress(struct zram *
> > * Iterate the secondary comp algorithms list (in order of priority)
> > * and try to recompress the page.
> > */
> > + prio_max = min(prio_max, ZRAM_MAX_COMPS);
> > for (; prio < prio_max; prio++) {
> > if (!zram->comps[prio])
> > continue;
> > _
>
> Hi Andrew,
>
> Please drop this patch. It makes reviewer think "oh, zram_recompress
> pass the higher prio_max value than the one zram allowed by somehow
> so we need to get the min value here", which is not true once review
> read code again/again and scratch head and then post patch to remove
> the unncessary line. I prefer reviewer happier.
I don't disagree. Let's drop it.
