On Mon, Nov 14, 2022 at 04:42:12PM -0800, Andrew Morton wrote: > > The patch titled > Subject: zram: explicitly limit prio_max for static analyzers > has been added to the -mm mm-unstable branch. Its filename is > zram-introduce-recompress-sysfs-knob-fix-2.patch > > This patch will shortly appear at > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-introduce-recompress-sysfs-knob-fix-2.patch > > This patch will later appear in the mm-unstable branch at > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** > > The -mm tree is included into linux-next via the mm-everything > branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > and is updated there every 2-3 working days > > ------------------------------------------------------ > From: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> > Subject: zram: explicitly limit prio_max for static analyzers > Date: Mon, 14 Nov 2022 11:14:20 +0900 > > Link: https://lkml.kernel.org/r/20221114021420.4060601-1-senozhatsky@xxxxxxxxxxxx > Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> > Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> > Cc: Minchan Kim <minchan@xxxxxxxxxx> > Cc: Nitin Gupta <ngupta@xxxxxxxxxx> > Cc: Suleiman Souhlal <suleiman@xxxxxxxxxx> > Cc: Kees Cook <keescook@xxxxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > > drivers/block/zram/zram_drv.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/block/zram/zram_drv.c~zram-introduce-recompress-sysfs-knob-fix-2 > +++ a/drivers/block/zram/zram_drv.c > @@ -1689,6 +1689,7 @@ static int zram_recompress(struct zram * > * Iterate the secondary comp algorithms list (in order of priority) > * and try to recompress the page. > */ > + prio_max = min(prio_max, ZRAM_MAX_COMPS); > for (; prio < prio_max; prio++) { > if (!zram->comps[prio]) > continue; > _ Hi Andrew, Please drop this patch. It makes reviewer think "oh, zram_recompress pass the higher prio_max value than the one zram allowed by somehow so we need to get the min value here", which is not true once review read code again/again and scratch head and then post patch to remove the unncessary line. I prefer reviewer happier.
