The patch titled gxfb: Support command line options has been added to the -mm tree. Its filename is gxfb-support-command-line-options.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: gxfb: Support command line options From: Jordan Crouse <jordan.crouse@xxxxxxx> Add support for command line options for setting the mode and various settings. Signed-off-by: Jordan Crouse <jordan.crouse@xxxxxxx> Cc: "Antonino A. Daplas" <adaplas@xxxxxxx> Cc: James Simmons <jsimmons@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/video/geode/gxfb_core.c | 36 +++++++++++++++++++++++++----- 1 files changed, 30 insertions(+), 6 deletions(-) diff -puN drivers/video/geode/gxfb_core.c~gxfb-support-command-line-options drivers/video/geode/gxfb_core.c --- a/drivers/video/geode/gxfb_core.c~gxfb-support-command-line-options +++ a/drivers/video/geode/gxfb_core.c @@ -35,10 +35,10 @@ #include "display_gx.h" #include "video_gx.h" -static char mode_option[32] = "640x480-16@60"; +static char *mode_option; /* Modes relevant to the GX (taken from modedb.c) */ -static const struct fb_videomode __initdata gx_modedb[] = { +static const struct fb_videomode gx_modedb[] __initdata = { /* 640x480-60 VESA */ { NULL, 60, 640, 480, 39682, 48, 16, 33, 10, 96, 2, 0, FB_VMODE_NONINTERLACED, FB_MODE_IS_VESA }, @@ -341,7 +341,8 @@ static int __init gxfb_probe(struct pci_ goto err; } - /* Clear the frame buffer of garbage. */ + + /* Clear the frame buffer of garbage. */ memset_io(info->screen_base, 0, info->fix.smem_len); gxfb_check_var(&info->var, info); @@ -411,11 +412,34 @@ static struct pci_driver gxfb_driver = { .remove = gxfb_remove, }; +#ifndef MODULE +static int __init gxfb_setup(char *options) { + + char *opt; + + if (!options || !*options) + return 0; + + while((opt = strsep(&options, ",")) != NULL) { + if (!*opt) + continue; + + mode_option = opt; + } + + return 0; +} +#endif + static int __init gxfb_init(void) { #ifndef MODULE - if (fb_get_options("gxfb", NULL)) + char *option = NULL; + + if (fb_get_options("gxfb", &option)) return -ENODEV; + + gxfb_setup(option); #endif return pci_register_driver(&gxfb_driver); } @@ -428,8 +452,8 @@ static void __exit gxfb_cleanup(void) module_init(gxfb_init); module_exit(gxfb_cleanup); -module_param_string(mode, mode_option, sizeof(mode_option), 0444); -MODULE_PARM_DESC(mode, "video mode (<x>x<y>[-<bpp>][@<refr>])"); +module_param(mode_option, charp, 0); +MODULE_PARM_DESC(mode_option, "video mode (<x>x<y>[-<bpp>][@<refr>])"); MODULE_DESCRIPTION("Framebuffer driver for the AMD Geode GX"); MODULE_LICENSE("GPL"); _ Patches currently in -mm which might be from jordan.crouse@xxxxxxx are acpi-clear-gpe-before-disabling-it.patch git-cryptodev.patch video-get-the-default-mode-from-the-right-database.patch fb-get-the-geode-gx-frambuffer-size-from-the-bios.patch gxfb-fixups-for-the-amd-geode-gx.patch gxfb-fixups-for-the-amd-geode-gx-tidy.patch gxfb-support-flat-panel-timings.patch gxfb-support-flat-panel-timings-tidy.patch gxfb-support-command-line-options.patch gxfb-support-command-line-options-tidy.patch gxfb-fixup-flatpanel-detection.patch gxfb-turn-on-the-flatpanel-power-and-data.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html