The patch titled Subject: um/sysrq: remove needless variable sp has been added to the -mm tree. Its filename is um-sysrq-remove-needless-variable-sp.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/um-sysrq-remove-needless-variable-sp.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/um-sysrq-remove-needless-variable-sp.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Dmitry Safonov <dima@xxxxxxxxxx> Subject: um/sysrq: remove needless variable sp `sp' is a needless excercise here. Link: http://lkml.kernel.org/r/20200418201944.482088-36-dima@xxxxxxxxxx Signed-off-by: Dmitry Safonov <dima@xxxxxxxxxx> Cc: Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx> Cc: Jeff Dike <jdike@xxxxxxxxxxx> Cc: Richard Weinberger <richard@xxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/um/kernel/sysrq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/arch/um/kernel/sysrq.c~um-sysrq-remove-needless-variable-sp +++ a/arch/um/kernel/sysrq.c @@ -27,7 +27,6 @@ static const struct stacktrace_ops stack void show_stack(struct task_struct *task, unsigned long *stack) { - unsigned long *sp = stack; struct pt_regs *segv_regs = current->thread.segv_regs; int i; @@ -38,10 +37,9 @@ void show_stack(struct task_struct *task } if (!stack) - sp = get_stack_pointer(task, segv_regs); + stack = get_stack_pointer(task, segv_regs); pr_info("Stack:\n"); - stack = sp; for (i = 0; i < 3 * STACKSLOTS_PER_LINE; i++) { if (kstack_end(stack)) break; _ Patches currently in -mm which might be from dima@xxxxxxxxxx are kallsyms-printk-add-loglvl-to-print_ip_sym.patch alpha-add-show_stack_loglvl.patch arc-add-show_stack_loglvl.patch arm-asm-add-loglvl-to-c_backtrace.patch arm-add-loglvl-to-unwind_backtrace.patch arm-add-loglvl-to-dump_backtrace.patch arm-wire-up-dump_backtrace_entrystm.patch arm-add-show_stack_loglvl.patch arm64-add-loglvl-to-dump_backtrace.patch arm64-add-show_stack_loglvl.patch c6x-add-show_stack_loglvl.patch csky-add-show_stack_loglvl.patch h8300-add-show_stack_loglvl.patch hexagon-add-show_stack_loglvl.patch ia64-pass-log-level-as-arg-into-ia64_do_show_stack.patch ia64-add-show_stack_loglvl.patch m68k-add-show_stack_loglvl.patch microblaze-add-loglvl-to-microblaze_unwind_inner.patch microblaze-add-loglvl-to-microblaze_unwind.patch microblaze-add-show_stack_loglvl.patch mips-add-show_stack_loglvl.patch nds32-add-show_stack_loglvl.patch nios2-add-show_stack_loglvl.patch openrisc-add-show_stack_loglvl.patch parisc-add-show_stack_loglvl.patch powerpc-add-show_stack_loglvl.patch riscv-add-show_stack_loglvl.patch s390-add-show_stack_loglvl.patch sh-add-loglvl-to-dump_mem.patch sh-remove-needless-printk.patch sh-add-loglvl-to-printk_address.patch sh-add-loglvl-to-show_trace.patch sh-add-show_stack_loglvl.patch sparc-add-show_stack_loglvl.patch um-sysrq-remove-needless-variable-sp.patch um-add-show_stack_loglvl.patch unicore32-remove-unused-pmode-argument-in-c_backtrace.patch unicore32-add-loglvl-to-c_backtrace.patch unicore32-add-show_stack_loglvl.patch x86-add-missing-const-qualifiers-for-log_lvl.patch x86-add-show_stack_loglvl.patch xtensa-add-loglvl-to-show_trace.patch xtensa-add-show_stack_loglvl.patch sysrq-use-show_stack_loglvl.patch x86-amd_gart-print-stacktrace-for-a-leak-with-kern_err.patch power-use-show_stack_loglvl.patch kdb-dont-play-with-console_loglevel.patch sched-print-stack-trace-with-kern_info.patch kernel-use-show_stack_loglvl.patch kernel-rename-show_stack_loglvl-=-show_stack.patch