The patch titled Subject: sparc: add show_stack_loglvl() has been added to the -mm tree. Its filename is sparc-add-show_stack_loglvl.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/sparc-add-show_stack_loglvl.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/sparc-add-show_stack_loglvl.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Dmitry Safonov <dima@xxxxxxxxxx> Subject: sparc: add show_stack_loglvl() Currently, the log-level of show_stack() depends on a platform realization. It creates situations where the headers are printed with lower log level or higher than the stacktrace (depending on a platform or user). Furthermore, it forces the logic decision from user to an architecture side. In result, some users as sysrq/kdb/etc are doing tricks with temporary rising console_loglevel while printing their messages. And in result it not only may print unwanted messages from other CPUs, but also omit printing at all in the unlucky case where the printk() was deferred. Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems an easier approach than introducing more printk buffers. Also, it will consolidate printings with headers. Introduce show_stack_loglvl(), that eventually will substitute show_stack(). [1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@xxxxxxxxxx/T/#u Link: http://lkml.kernel.org/r/20200418201944.482088-35-dima@xxxxxxxxxx Signed-off-by: Dmitry Safonov <dima@xxxxxxxxxx> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/sparc/kernel/process_32.c | 17 ++++++++++++----- arch/sparc/kernel/traps_64.c | 15 +++++++++++---- 2 files changed, 23 insertions(+), 9 deletions(-) --- a/arch/sparc/kernel/process_32.c~sparc-add-show_stack_loglvl +++ a/arch/sparc/kernel/process_32.c @@ -145,10 +145,12 @@ void show_regs(struct pt_regs *r) } /* - * The show_stack is an external API which we do not use ourselves. + * The show_stack(), show_stack_loglvl() are external APIs which + * we do not use ourselves. * The oops is printed in die_if_kernel. */ -void show_stack(struct task_struct *tsk, unsigned long *_ksp) +void show_stack_loglvl(struct task_struct *tsk, unsigned long *_ksp, + const char *loglvl) { unsigned long pc, fp; unsigned long task_base; @@ -170,11 +172,16 @@ void show_stack(struct task_struct *tsk, break; rw = (struct reg_window32 *) fp; pc = rw->ins[7]; - printk("[%08lx : ", pc); - printk("%pS ] ", (void *) pc); + printk("%s[%08lx : ", loglvl, pc); + printk("%s%pS ] ", loglvl, (void *) pc); fp = rw->ins[6]; } while (++count < 16); - printk("\n"); + printk("%s\n", loglvl); +} + +void show_stack(struct task_struct *task, unsigned long *sp) +{ + show_stack_loglvl(task, sp, KERN_DEFAULT); } /* --- a/arch/sparc/kernel/traps_64.c~sparc-add-show_stack_loglvl +++ a/arch/sparc/kernel/traps_64.c @@ -18,6 +18,7 @@ #include <linux/smp.h> #include <linux/mm.h> #include <linux/init.h> +#include <linux/kallsyms.h> #include <linux/kdebug.h> #include <linux/ftrace.h> #include <linux/reboot.h> @@ -2452,7 +2453,8 @@ static void user_instruction_dump(unsign printk("\n"); } -void show_stack(struct task_struct *tsk, unsigned long *_ksp) +void show_stack_loglvl(struct task_struct *tsk, unsigned long *_ksp, + const char *loglvl) { unsigned long fp, ksp; struct thread_info *tp; @@ -2476,7 +2478,7 @@ void show_stack(struct task_struct *tsk, fp = ksp + STACK_BIAS; - printk("Call Trace:\n"); + printk("%sCall Trace:\n", loglvl); do { struct sparc_stackf *sf; struct pt_regs *regs; @@ -2497,14 +2499,14 @@ void show_stack(struct task_struct *tsk, fp = (unsigned long)sf->fp + STACK_BIAS; } - printk(" [%016lx] %pS\n", pc, (void *) pc); + print_ip_sym(loglvl, pc); #ifdef CONFIG_FUNCTION_GRAPH_TRACER if ((pc + 8UL) == (unsigned long) &return_to_handler) { struct ftrace_ret_stack *ret_stack; ret_stack = ftrace_graph_get_ret_stack(tsk, graph); if (ret_stack) { pc = ret_stack->ret; - printk(" [%016lx] %pS\n", pc, (void *) pc); + print_ip_sym(loglvl, pc); graph++; } } @@ -2512,6 +2514,11 @@ void show_stack(struct task_struct *tsk, } while (++count < 16); } +void show_stack(struct task_struct *tsk, unsigned long *_ksp) +{ + show_stack_loglvl(task, sp, KERN_DEFAULT); +} + static inline struct reg_window *kernel_stack_up(struct reg_window *rw) { unsigned long fp = rw->ins[6]; _ Patches currently in -mm which might be from dima@xxxxxxxxxx are kallsyms-printk-add-loglvl-to-print_ip_sym.patch alpha-add-show_stack_loglvl.patch arc-add-show_stack_loglvl.patch arm-asm-add-loglvl-to-c_backtrace.patch arm-add-loglvl-to-unwind_backtrace.patch arm-add-loglvl-to-dump_backtrace.patch arm-wire-up-dump_backtrace_entrystm.patch arm-add-show_stack_loglvl.patch arm64-add-loglvl-to-dump_backtrace.patch arm64-add-show_stack_loglvl.patch c6x-add-show_stack_loglvl.patch csky-add-show_stack_loglvl.patch h8300-add-show_stack_loglvl.patch hexagon-add-show_stack_loglvl.patch ia64-pass-log-level-as-arg-into-ia64_do_show_stack.patch ia64-add-show_stack_loglvl.patch m68k-add-show_stack_loglvl.patch microblaze-add-loglvl-to-microblaze_unwind_inner.patch microblaze-add-loglvl-to-microblaze_unwind.patch microblaze-add-show_stack_loglvl.patch mips-add-show_stack_loglvl.patch nds32-add-show_stack_loglvl.patch nios2-add-show_stack_loglvl.patch openrisc-add-show_stack_loglvl.patch parisc-add-show_stack_loglvl.patch powerpc-add-show_stack_loglvl.patch riscv-add-show_stack_loglvl.patch s390-add-show_stack_loglvl.patch sh-add-loglvl-to-dump_mem.patch sh-remove-needless-printk.patch sh-add-loglvl-to-printk_address.patch sh-add-loglvl-to-show_trace.patch sh-add-show_stack_loglvl.patch sparc-add-show_stack_loglvl.patch um-sysrq-remove-needless-variable-sp.patch um-add-show_stack_loglvl.patch unicore32-remove-unused-pmode-argument-in-c_backtrace.patch unicore32-add-loglvl-to-c_backtrace.patch unicore32-add-show_stack_loglvl.patch x86-add-missing-const-qualifiers-for-log_lvl.patch x86-add-show_stack_loglvl.patch xtensa-add-loglvl-to-show_trace.patch xtensa-add-show_stack_loglvl.patch sysrq-use-show_stack_loglvl.patch x86-amd_gart-print-stacktrace-for-a-leak-with-kern_err.patch power-use-show_stack_loglvl.patch kdb-dont-play-with-console_loglevel.patch sched-print-stack-trace-with-kern_info.patch kernel-use-show_stack_loglvl.patch kernel-rename-show_stack_loglvl-=-show_stack.patch