The patch titled
Subject: mm/filemap.c: remove redundant cache invalidation after async direct-io write
has been added to the -mm tree. Its filename is
fs-remove-redundant-cache-invalidation-after-async-direct-io-write.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/fs-remove-redundant-cache-invalidation-after-async-direct-io-write.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/fs-remove-redundant-cache-invalidation-after-async-direct-io-write.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx>
Subject: mm/filemap.c: remove redundant cache invalidation after async direct-io write
generic_file_direct_write() invalidates cache at entry. Second time this
should be done when request completes. But this function calls second
invalidation at exit unconditionally even for async requests.
This patch skips second invalidation for async requests (-EIOCBQUEUED).
Link: http://lkml.kernel.org/r/157270037850.4812.15036239021726025572.stgit@buzz
Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Jens Axboe <axboe@xxxxxxxxx>
Cc: Jan Kara <jack@xxxxxxx>
Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/filemap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--- a/mm/filemap.c~fs-remove-redundant-cache-invalidation-after-async-direct-io-write
+++ a/mm/filemap.c
@@ -3218,9 +3218,11 @@ generic_file_direct_write(struct kiocb *
* Most of the time we do not need this since dio_complete() will do
* the invalidation for us. However there are some file systems that
* do not end up with dio_complete() being called, so let's not break
- * them by removing it completely
+ * them by removing it completely.
+ *
+ * Skip invalidation for async writes or if mapping has no pages.
*/
- if (mapping->nrpages)
+ if (written > 0 && mapping->nrpages)
invalidate_inode_pages2_range(mapping,
pos >> PAGE_SHIFT, end);
_
Patches currently in -mm which might be from khlebnikov@xxxxxxxxxxxxxx are
fs-remove-redundant-cache-invalidation-after-async-direct-io-write.patch
fs-keep-dio_warn_stale_pagecache-when-config_block=n.patch
fs-warn-if-stale-pagecache-is-left-after-direct-write.patch
mm-swap-piggyback-lru_add_drain_all-calls.patch
mm-vmstat-add-helpers-to-get-vmstat-item-names-for-each-enum-type.patch
mm-vmstat-do-not-use-size-of-vmstat_text-as-count-of-proc-vmstat-items.patch
mm-memcontrol-use-vmstat-names-for-printing-statistics.patch
