The patch titled
Subject: mm/vmscan: fix an undefined behavior for zone id
has been added to the -mm tree. Its filename is
mm-vmscan-simplify-lruvec_lru_size-fix.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-vmscan-simplify-lruvec_lru_size-fix.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-vmscan-simplify-lruvec_lru_size-fix.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Qian Cai <cai@xxxxxx>
Subject: mm/vmscan: fix an undefined behavior for zone id
The -next commit "mm: vmscan: simplify lruvec_lru_size()" [1] introduced
an undefined behavior as zone_idx could equal to MAX_NR_ZONES, and then
zid is then out of range.
[ 5399.483257] LTP: starting mtest01w (mtest01 -p80 -w)
[ 5400.245051] ================================================================================
[ 5400.255784] UBSAN: Undefined behaviour in ./include/linux/memcontrol.h:536:26
[ 5400.265235] index 5 is out of range for type 'long unsigned int [5][5]'
[ 5400.273925] CPU: 28 PID: 455 Comm: kswapd7 Tainted: G W 5.4.0-rc6-next-20191108 #3
[ 5400.285461] Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019
[ 5400.295784] Call Trace:
[ 5400.299483] dump_stack+0x7a/0xaa
[ 5400.304052] ubsan_epilogue+0x9/0x26
[ 5400.309180] __ubsan_handle_out_of_bounds.cold.13+0x2b/0x36
[ 5400.316192] inactive_list_is_low+0x8bb/0x9f0
[ 5400.321952] balance_pgdat+0x252/0x7d0
[ 5400.327006] kswapd+0x251/0x590
[ 5400.331725] ? finish_wait+0x90/0x90
[ 5400.336574] kthread+0x12a/0x140
[ 5400.341102] ? balance_pgdat+0x7d0/0x7d0
[ 5400.346330] ? kthread_create_worker_on_cpu+0x70/0x70
[ 5400.352810] ret_from_fork+0x27/0x50
[1] https://lore.kernel.org/linux-mm/20191022144803.302233-2-hannes@xxxxxxxxxxx/
Link: http://lkml.kernel.org/r/20191108204407.1435-1-cai@xxxxxx
Signed-off-by: Qian Cai <cai@xxxxxx>
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Cc: Roman Gushchin <guro@xxxxxx>
Cc: Shakeel Butt <shakeelb@xxxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/vmscan.c~mm-vmscan-simplify-lruvec_lru_size-fix
+++ a/mm/vmscan.c
@@ -354,7 +354,7 @@ unsigned long lruvec_lru_size(struct lru
unsigned long size = 0;
int zid;
- for (zid = 0; zid <= zone_idx; zid++) {
+ for (zid = 0; zid < zone_idx; zid++) {
struct zone *zone = &lruvec_pgdat(lruvec)->node_zones[zid];
if (!managed_zone(zone))
_
Patches currently in -mm which might be from cai@xxxxxx are
mm-vmscan-simplify-lruvec_lru_size-fix.patch
z3fold-add-inter-page-compaction-fix.patch
hugetlb-remove-unused-hstate-in-hugetlb_fault_mutex_hash-fix-fix.patch
mm-add-generic-ptdump-v15-fix.patch
