The patch titled
Subject: tools/testing/selftests/sysctl/sysctl.sh: remove superfluous test_reqs()
has been added to the -mm tree. Its filename is
test_sysctl-remove-superfluous-test_reqs.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/test_sysctl-remove-superfluous-test_reqs.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/test_sysctl-remove-superfluous-test_reqs.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Subject: tools/testing/selftests/sysctl/sysctl.sh: remove superfluous test_reqs()
Patch series "sysctl: add pending proc_do_large_bitmap fix".
Eric sent a fix out for proc_do_large_bitmap() last month for when using a
large input buffer. After patch review a test case for the issue was
built and submitted. I noticed there were a few issues with the tests,
but instead of just asking Eric to address them I've taken care of them
and ammended the commit where necessary. There's a few issues he reported
which I also address and fix in this series.
Since we *do* expect users of these scripts to also use them on older
kernels, I've also addressed not breaking calling the script for them, and
gives us an easy way to easily extend our tests cases for future kernels
as well.
Before anyone considers these for stable as minor fixes, I'd recommend we
also address the discrepancy on the read side of things: modify the test
script to use diff against the target file instead of using the temp file.
This patch (of 6):
We already call test_reqs(), no need to call it twice.
Link: http://lkml.kernel.org/r/20190320222831.8243-2-mcgrof@xxxxxxxxxx
Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
tools/testing/selftests/sysctl/sysctl.sh | 2 --
1 file changed, 2 deletions(-)
--- a/tools/testing/selftests/sysctl/sysctl.sh~test_sysctl-remove-superfluous-test_reqs
+++ a/tools/testing/selftests/sysctl/sysctl.sh
@@ -675,8 +675,6 @@ list_tests()
echo "0005 x $(get_test_count 0005) - tests proc_douintvec() array"
}
-test_reqs
-
usage()
{
NUM_TESTS=$(grep -o ' ' <<<"$ALL_TESTS" | grep -c .)
_
Patches currently in -mm which might be from mcgrof@xxxxxxxxxx are
test_sysctl-remove-superfluous-test_reqs.patch
test_sysctl-load-module-before-testing-for-it.patch
test_sysctl-ignore-diff-output-on-verify_diff_w.patch
test_sysctl-allow-graceful-use-on-older-kernels.patch
