[merged] hfs-do-not-free-node-before-using.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: hfs: do not free node before using
has been removed from the -mm tree.  Its filename was
     hfs-do-not-free-node-before-using.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Pan Bian <bianpan2016@xxxxxxx>
Subject: hfs: do not free node before using

hfs_bmap_free() frees the node via hfs_bnode_put(node).  However, it then
reads node->this when dumping error message on an error path, which may
result in a use-after-free bug.  This patch frees the node only when it is
never again used.

Link: http://lkml.kernel.org/r/1542963889-128825-1-git-send-email-bianpan2016@xxxxxxx
Fixes: a1185ffa2fc ("HFS rewrite")
Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Joe Perches <joe@xxxxxxxxxxx>
Cc: Ernesto A. Fernandez <ernesto.mnd.fernandez@xxxxxxxxx>
Cc: Viacheslav Dubeyko <slava@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 fs/hfs/btree.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/fs/hfs/btree.c~hfs-do-not-free-node-before-using
+++ a/fs/hfs/btree.c
@@ -338,13 +338,14 @@ void hfs_bmap_free(struct hfs_bnode *nod
 
 		nidx -= len * 8;
 		i = node->next;
-		hfs_bnode_put(node);
 		if (!i) {
 			/* panic */;
 			pr_crit("unable to free bnode %u. bmap not found!\n",
 				node->this);
+			hfs_bnode_put(node);
 			return;
 		}
+		hfs_bnode_put(node);
 		node = hfs_bnode_find(tree, i);
 		if (IS_ERR(node))
 			return;
_

Patches currently in -mm which might be from bianpan2016@xxxxxxx are





[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux