The patch titled
Subject: hfs: fix return value of hfs_get_block()
has been added to the -mm tree. Its filename is
hfs-fix-return-value-of-hfs_get_block.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/hfs-fix-return-value-of-hfs_get_block.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/hfs-fix-return-value-of-hfs_get_block.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Ernesto A. Fernandez <ernesto.mnd.fernandez@xxxxxxxxx>
Subject: hfs: fix return value of hfs_get_block()
Direct writes to empty inodes fail with EIO. The generic direct-io code
is in part to blame (a patch has been submitted as "direct-io: allow
direct writes to empty inodes"), but hfs is worse affected than the other
filesystems because the fallback to buffered I/O doesn't happen.
The problem is the return value of hfs_get_block() when called with
!create. Change it to be more consistent with the other modules.
Link: http://lkml.kernel.org/r/4538ab8c35ea37338490525f0f24cbc37227528c.1539195310.git.ernesto.mnd.fernandez@xxxxxxxxx
Signed-off-by: Ernesto A. Fernandez <ernesto.mnd.fernandez@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
diff -puN fs/hfs/extent.c~hfs-fix-return-value-of-hfs_get_block fs/hfs/extent.c
--- a/fs/hfs/extent.c~hfs-fix-return-value-of-hfs_get_block
+++ a/fs/hfs/extent.c
@@ -345,7 +345,9 @@ int hfs_get_block(struct inode *inode, s
ablock = (u32)block / HFS_SB(sb)->fs_div;
if (block >= HFS_I(inode)->fs_blocks) {
- if (block > HFS_I(inode)->fs_blocks || !create)
+ if (!create)
+ return 0;
+ if (block > HFS_I(inode)->fs_blocks)
return -EIO;
if (ablock >= HFS_I(inode)->alloc_blocks) {
res = hfs_extend_file(inode);
_
Patches currently in -mm which might be from ernesto.mnd.fernandez@xxxxxxxxx are
hfsplus-prevent-btree-data-loss-on-root-split.patch
hfsplus-fix-bug-on-bnode-parent-update.patch
hfs-prevent-btree-data-loss-on-root-split.patch
hfs-fix-bug-on-bnode-parent-update.patch
hfsplus-prevent-btree-data-loss-on-enospc.patch
hfs-prevent-btree-data-loss-on-enospc.patch
hfsplus-fix-return-value-of-hfsplus_get_block.patch
hfs-fix-return-value-of-hfs_get_block.patch
