The patch titled
Subject: scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation
has been added to the -mm tree. Its filename is
scripts-tagssh-dont-parse-ls-for-allsource_archs-generation.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/scripts-tagssh-dont-parse-ls-for-allsource_archs-generation.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/scripts-tagssh-dont-parse-ls-for-allsource_archs-generation.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Joey Pabalinas <joeypabalinas@xxxxxxxxx>
Subject: scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation
Parsing `ls` is fragile at best and _will_ fail when $tree contains
spaces. Replace this with a glob-generated string and directly assign it
to $ALLSOURCE_ARCHS; a subshell is implied by $(), so `cd` doesn't affect
the current working directory.
Link: http://lkml.kernel.org/r/20180517212621.i6ljgrcfhhadrkij@xxxxxxxxx
Signed-off-by: Joey Pabalinas <joeypabalinas@xxxxxxxxx>
Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Cc: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Cc: Robert Jarzmik <robert.jarzmik@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/tags.sh | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff -puN scripts/tags.sh~scripts-tagssh-dont-parse-ls-for-allsource_archs-generation scripts/tags.sh
--- a/scripts/tags.sh~scripts-tagssh-dont-parse-ls-for-allsource_archs-generation
+++ a/scripts/tags.sh
@@ -31,10 +31,7 @@ ignore="$ignore ( -path ${tree}tools ) -
# Find all available archs
find_all_archs()
{
- ALLSOURCE_ARCHS=""
- for arch in `ls ${tree}arch`; do
- ALLSOURCE_ARCHS="${ALLSOURCE_ARCHS} "${arch##\/}
- done
+ ALLSOURCE_ARCHS="$(cd "${tree}arch/" && echo *)"
}
# Detect if ALLSOURCE_ARCHS is set. If not, we assume SRCARCH
_
Patches currently in -mm which might be from joeypabalinas@xxxxxxxxx are
scripts-tagssh-dont-parse-ls-for-allsource_archs-generation.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
