The patch titled
Subject: membarrier: clean up selftest
has been added to the -mm tree. Its filename is
cleanup-membarrier-selftest.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/cleanup-membarrier-selftest.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/cleanup-membarrier-selftest.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
Subject: membarrier: clean up selftest
We don't need to specify an explicit rule in the Makefile, the implicit
one will do the same. The "__EXPORTED_HEADERS__" define is not needed,
because we build the test against the installed kernel headers, not the
in-tree kernel headers. Re-use "$(TEST_PROGS)" in the clean target rather
than spelling the executable name twice. Include <unistd.h> rather than
the rather specific <asm-generic/unistd.h>. Include <syscall.h> rather
than <sys/syscall.h>. In both cases, the former header is located in a
standard location and includes the latter.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Cc: Pranith Kumar <bobby.prani@xxxxxxxxx>
Cc: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
tools/testing/selftests/membarrier/Makefile | 7 +++----
tools/testing/selftests/membarrier/membarrier_test.c | 5 +----
2 files changed, 4 insertions(+), 8 deletions(-)
diff -puN tools/testing/selftests/membarrier/Makefile~cleanup-membarrier-selftest tools/testing/selftests/membarrier/Makefile
--- a/tools/testing/selftests/membarrier/Makefile~cleanup-membarrier-selftest
+++ a/tools/testing/selftests/membarrier/Makefile
@@ -1,11 +1,10 @@
CFLAGS += -g -I../../../../usr/include/
-all:
- $(CC) $(CFLAGS) membarrier_test.c -o membarrier_test
-
TEST_PROGS := membarrier_test
+all: $(TEST_PROGS)
+
include ../lib.mk
clean:
- $(RM) membarrier_test
+ $(RM) $(TEST_PROGS)
diff -puN tools/testing/selftests/membarrier/membarrier_test.c~cleanup-membarrier-selftest tools/testing/selftests/membarrier/membarrier_test.c
--- a/tools/testing/selftests/membarrier/membarrier_test.c~cleanup-membarrier-selftest
+++ a/tools/testing/selftests/membarrier/membarrier_test.c
@@ -1,9 +1,6 @@
#define _GNU_SOURCE
-#define __EXPORTED_HEADERS__
-
#include <linux/membarrier.h>
-#include <asm-generic/unistd.h>
-#include <sys/syscall.h>
+#include <syscall.h>
#include <stdio.h>
#include <errno.h>
#include <string.h>
_
Patches currently in -mm which might be from mathieu.desnoyers@xxxxxxxxxxxx are
cleanup-membarrier-selftest.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
