The patch titled
Subject: omfs: fix sign confusion for bitmap loop counter
has been added to the -mm tree. Its filename is
omfs-fix-sign-confusion-for-bitmap-loop-counter.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/omfs-fix-sign-confusion-for-bitmap-loop-counter.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/omfs-fix-sign-confusion-for-bitmap-loop-counter.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Bob Copeland <me@xxxxxxxxxxxxxxx>
Subject: omfs: fix sign confusion for bitmap loop counter
The count variable is used to iterate down to (below) zero from the size
of the bitmap and handle the one-filling the remainder of the last partial
bitmap block. The loop conditional expects count to be signed in order to
detect when the final block is processed, after which count goes negative.
Unfortunately, a recent change made this unsigned along with some other
related fields. The result of is this is that during mount, omfs_get_imap
will overrun the bitmap array and corrupt memory unless number of blocks
happens to be a multiple of 8 * blocksize.
Fix by changing count back to signed: it is guaranteed to fit in an s32
without overflow due to an enforced limit on the number of blocks in the
filesystem.
Signed-off-by: Bob Copeland <me@xxxxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/omfs/inode.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN fs/omfs/inode.c~omfs-fix-sign-confusion-for-bitmap-loop-counter fs/omfs/inode.c
--- a/fs/omfs/inode.c~omfs-fix-sign-confusion-for-bitmap-loop-counter
+++ a/fs/omfs/inode.c
@@ -306,7 +306,8 @@ static const struct super_operations omf
*/
static int omfs_get_imap(struct super_block *sb)
{
- unsigned int bitmap_size, count, array_size;
+ unsigned int bitmap_size, array_size;
+ int count;
struct omfs_sb_info *sbi = OMFS_SB(sb);
struct buffer_head *bh;
unsigned long **ptr;
_
Patches currently in -mm which might be from me@xxxxxxxxxxxxxxx are
fs-omfs-add-null-terminator-in-the-end-up-the-token-list.patch
omfs-set-error-return-when-d_make_root-fails.patch
omfs-fix-sign-confusion-for-bitmap-loop-counter.patch
omfs-fix-potential-integer-overflow-in-allocator.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
