The patch titled
Subject: omfs: set error return when d_make_root() fails
has been added to the -mm tree. Its filename is
omfs-set-error-return-when-d_make_root-fails.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/omfs-set-error-return-when-d_make_root-fails.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/omfs-set-error-return-when-d_make_root-fails.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Bob Copeland <me@xxxxxxxxxxxxxxx>
Subject: omfs: set error return when d_make_root() fails
A static checker found the following issue in the error path for
omfs_fill_super:
fs/omfs/inode.c:552 omfs_fill_super()
warn: missing error code here? 'd_make_root()' failed. 'ret' = '0'
Fix by returning -ENOMEM in this case.
Signed-off-by: Bob Copeland <me@xxxxxxxxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/omfs/inode.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN fs/omfs/inode.c~omfs-set-error-return-when-d_make_root-fails fs/omfs/inode.c
--- a/fs/omfs/inode.c~omfs-set-error-return-when-d_make_root-fails
+++ a/fs/omfs/inode.c
@@ -549,8 +549,10 @@ static int omfs_fill_super(struct super_
}
sb->s_root = d_make_root(root);
- if (!sb->s_root)
+ if (!sb->s_root) {
+ ret = -ENOMEM;
goto out_brelse_bh2;
+ }
printk(KERN_DEBUG "omfs: Mounted volume %s\n", omfs_rb->r_name);
ret = 0;
_
Patches currently in -mm which might be from me@xxxxxxxxxxxxxxx are
fs-omfs-add-null-terminator-in-the-end-up-the-token-list.patch
omfs-set-error-return-when-d_make_root-fails.patch
omfs-fix-sign-confusion-for-bitmap-loop-counter.patch
omfs-fix-potential-integer-overflow-in-allocator.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
