Subject: + checkpatchpl-modify-warning-message-for-printk-usage.patch added to -mm tree To: mr.yogesh@xxxxxxxxx,joe@xxxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Wed, 05 Mar 2014 13:39:49 -0800 The patch titled Subject: checkpatch.pl: modify warning message for printk usage has been added to the -mm tree. Its filename is checkpatchpl-modify-warning-message-for-printk-usage.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/checkpatchpl-modify-warning-message-for-printk-usage.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/checkpatchpl-modify-warning-message-for-printk-usage.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Yogesh Chaudhari <mr.yogesh@xxxxxxxxx> Subject: checkpatch.pl: modify warning message for printk usage Modify warning message when printk is used in a patch. It mentions to use subsystem_dbg instead of netdev_dbg as the first preferred format of logging debug messages. Signed-off-by: Yogesh Chaudhari <mr.yogesh@xxxxxxxxx> Cc: Joe Perches <joe@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN scripts/checkpatch.pl~checkpatchpl-modify-warning-message-for-printk-usage scripts/checkpatch.pl --- a/scripts/checkpatch.pl~checkpatchpl-modify-warning-message-for-printk-usage +++ a/scripts/checkpatch.pl @@ -2833,7 +2833,7 @@ sub process { my $level2 = $level; $level2 = "dbg" if ($level eq "debug"); WARN("PREFER_PR_LEVEL", - "Prefer netdev_$level2(netdev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr); + "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr); } if ($line =~ /\bpr_warning\s*\(/) { _ Patches currently in -mm which might be from mr.yogesh@xxxxxxxxx are checkpatchpl-modify-warning-message-for-printk-usage.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html