Subject: + fs-pipec-skip-file_update_time-on-frozen-fs.patch added to -mm tree To: dmonakhov@xxxxxxxxxx,jack@xxxxxxx,viro@xxxxxxxxxxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Mon, 16 Dec 2013 11:55:56 -0800 The patch titled Subject: fs/pipe.c: skip file_update_time on frozen fs has been added to the -mm tree. Its filename is fs-pipec-skip-file_update_time-on-frozen-fs.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/fs-pipec-skip-file_update_time-on-frozen-fs.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/fs-pipec-skip-file_update_time-on-frozen-fs.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> Subject: fs/pipe.c: skip file_update_time on frozen fs Pipe has no data associated with fs so it is not good idea to block pipe_write() if FS is frozen, but we can not update file's time on such filesystem. Let's use same idea as we use in touch_time(). Addresses https://bugzilla.kernel.org/show_bug.cgi?id=65701 Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> Reviewed-by: Jan Kara <jack@xxxxxxx> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN fs/pipe.c~fs-pipec-skip-file_update_time-on-frozen-fs fs/pipe.c --- a/fs/pipe.c~fs-pipec-skip-file_update_time-on-frozen-fs +++ a/fs/pipe.c @@ -663,10 +663,11 @@ out: wake_up_interruptible_sync_poll(&pipe->wait, POLLIN | POLLRDNORM); kill_fasync(&pipe->fasync_readers, SIGIO, POLL_IN); } - if (ret > 0) { + if (ret > 0 && sb_start_write_trylock(file_inode(filp)->i_sb)) { int err = file_update_time(filp); if (err) ret = err; + sb_end_write(file_inode(filp)->i_sb); } return ret; } _ Patches currently in -mm which might be from dmonakhov@xxxxxxxxxx are fs-pipec-skip-file_update_time-on-frozen-fs.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html