Subject: + romfs-fix-returm-err-while-getting-inode-in-fill_super.patch added to -mm tree To: rui.xiang@xxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Mon, 16 Dec 2013 11:55:57 -0800 The patch titled Subject: romfs: fix returm err while getting inode in fill_super has been added to the -mm tree. Its filename is romfs-fix-returm-err-while-getting-inode-in-fill_super.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/romfs-fix-returm-err-while-getting-inode-in-fill_super.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/romfs-fix-returm-err-while-getting-inode-in-fill_super.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Rui Xiang <rui.xiang@xxxxxxxxxx> Subject: romfs: fix returm err while getting inode in fill_super Getting an inode by romfs_iget may lead to an err in fill_super, and the err value should be return. And it should return -ENOMEM instead while d_make_root fails, fix it too. Signed-off-by: Rui Xiang <rui.xiang@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/romfs/super.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff -puN fs/romfs/super.c~romfs-fix-returm-err-while-getting-inode-in-fill_super fs/romfs/super.c --- a/fs/romfs/super.c~romfs-fix-returm-err-while-getting-inode-in-fill_super +++ a/fs/romfs/super.c @@ -533,16 +533,14 @@ static int romfs_fill_super(struct super root = romfs_iget(sb, pos); if (IS_ERR(root)) - goto error; + return PTR_ERR(root); sb->s_root = d_make_root(root); if (!sb->s_root) - goto error; + return -ENOMEM; return 0; -error: - return -EINVAL; error_rsb_inval: ret = -EINVAL; error_rsb: _ Patches currently in -mm which might be from rui.xiang@xxxxxxxxxx are autofs-fix-the-return-value-of-autofs4_fill_super.patch autofs-use-is_root-to-replace-root-dentry-checks.patch proc-set-attributes-of-pde-using-accessor-functions.patch romfs-fix-returm-err-while-getting-inode-in-fill_super.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html