The patch titled
buglet in radix_tree_tag_set
has been removed from the -mm tree. Its filename is
buglet-in-radix_tree_tag_set.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
Subject: buglet in radix_tree_tag_set
From: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
The comment states: 'Setting a tag on a not-present item is a BUG.' Hence
if 'index' is larger than the maxindex; the item _cannot_ be presen; it
should also be a BUG.
Also, this allows the following statement (assume a fresh tree):
radix_tree_tag_set(root, 16, 1);
to fail silently, but when preceded by:
radix_tree_insert(root, 32, item);
it would BUG, because the height has been extended by the insert.
In neither case was 16 present.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Acked-by: Nick Piggin <npiggin@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
lib/radix-tree.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -puN lib/radix-tree.c~buglet-in-radix_tree_tag_set lib/radix-tree.c
--- a/lib/radix-tree.c~buglet-in-radix_tree_tag_set
+++ a/lib/radix-tree.c
@@ -389,8 +389,7 @@ void *radix_tree_tag_set(struct radix_tr
struct radix_tree_node *slot;
height = root->height;
- if (index > radix_tree_maxindex(height))
- return NULL;
+ BUG_ON(index > radix_tree_maxindex(height));
slot = root->rnode;
shift = (height - 1) * RADIX_TREE_MAP_SHIFT;
_
Patches currently in -mm which might be from a.p.zijlstra@xxxxxxxxx are
origin.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
