The patch titled
NFS server subtree_check returns dubious value
has been removed from the -mm tree. Its filename is
nfs-server-subtree_check-returns-dubious-value.patch
This patch was probably dropped from -mm because
it has now been merged into a subsystem tree or
into Linus's tree, or because it was folded into
its parent patch in the -mm tree.
------------------------------------------------------
Subject: NFS server subtree_check returns dubious value
From: Peter Staubach <staubach@xxxxxxxxxx>
Address a problem found when a Linux NFS server uses the "subtree_check"
export option.
The "subtree_check" NFS export option was designed to prohibit a client
from using a file handle for which it should not have permission. The
algorithm used is to ensure that the entire path to the file being
referenced is accessible to the user attempting to use the file handle. If
some part of the path is not accessible, then the operation is aborted and
the appropriate version of ESTALE is returned to the NFS client.
The error, ESTALE, is unfortunate in that it causes NFS clients to make
certain assumptions about the continued existence of the file. They assume
that the file no longer exists and refuse to attempt to access it again.
In this case, the file really does exist, but access was denied by the
server for a particular user.
A better error to return would be an EACCES sort of error. This would
inform the client that the particular operation that it was attempting was
not allowed, without the nasty side effects of the ESTALE error.
Signed-off-by: Peter Staubach <staubach@xxxxxxxxxx>
Acked-By: NeilBrown <neilb@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
fs/exportfs/expfs.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/exportfs/expfs.c~nfs-server-subtree_check-returns-dubious-value fs/exportfs/expfs.c
--- devel/fs/exportfs/expfs.c~nfs-server-subtree_check-returns-dubious-value 2006-05-20 14:59:34.000000000 -0700
+++ devel-akpm/fs/exportfs/expfs.c 2006-05-20 14:59:34.000000000 -0700
@@ -102,7 +102,7 @@ find_exported_dentry(struct super_block
if (acceptable(context, result))
return result;
if (S_ISDIR(result->d_inode->i_mode)) {
- /* there is no other dentry, so fail */
+ err = -EACCES;
goto err_result;
}
_
Patches currently in -mm which might be from staubach@xxxxxxxxxx are
origin.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
