The patch titled
nfsd: sign conversion obscuring errors in nfsd_set_posix_acl()
has been removed from the -mm tree. Its filename is
nfsd-sign-conversion-obscuring-errors-in-nfsd_set_posix_acl.patch
This patch was probably dropped from -mm because
it has now been merged into a subsystem tree or
into Linus's tree, or because it was folded into
its parent patch in the -mm tree.
------------------------------------------------------
Subject: nfsd: sign conversion obscuring errors in nfsd_set_posix_acl()
From: Florin Malita <fmalita@xxxxxxxxx>
Assigning the result of posix_acl_to_xattr() to an unsigned data type
(size/size_t) obscures possible errors.
Coverity CID: 1206.
Signed-off-by: Florin Malita <fmalita@xxxxxxxxx>
Acked-by: NeilBrown <neilb@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
fs/nfsd/vfs.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff -puN fs/nfsd/vfs.c~nfsd-sign-conversion-obscuring-errors-in-nfsd_set_posix_acl fs/nfsd/vfs.c
--- devel/fs/nfsd/vfs.c~nfsd-sign-conversion-obscuring-errors-in-nfsd_set_posix_acl 2006-05-20 14:59:34.000000000 -0700
+++ devel-akpm/fs/nfsd/vfs.c 2006-05-20 14:59:34.000000000 -0700
@@ -1922,11 +1922,10 @@ nfsd_set_posix_acl(struct svc_fh *fhp, i
value = kmalloc(size, GFP_KERNEL);
if (!value)
return -ENOMEM;
- size = posix_acl_to_xattr(acl, value, size);
- if (size < 0) {
- error = size;
+ error = posix_acl_to_xattr(acl, value, size);
+ if (error < 0)
goto getout;
- }
+ size = error;
} else
size = 0;
_
Patches currently in -mm which might be from fmalita@xxxxxxxxx are
origin.patch
git-mtd.patch
orinoco-possible-null-pointer-dereference-in-orinoco_rx_monitor.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
