Hi Paul, > > > -# ifdef CONFIG_SYS_SUPPORTS_MICROMIPS > > > +# if defined(__mips_micromips) > > > > Wouldn't it be cleaner if it was written: > > > > # if defined(CONFIG_CPU_MICROMIPS) > > I suppose it's just a matter of preference - in practice both ought to > be defined or undefined at the same times. My personal preference is the > standard macro provided by the compiler, so that's what I used. The minor difference as I see it is that CONFIG_CPU_MICROMIPS is ours and the primary knob while `__mips_micromips' is GCC's. I don't see it as a big problem if any at all, it's just my guts feeling. Do we have a consistency check between the two macros anywhere? Maciej
