Hi Maciej,
On Wed, Nov 28, 2018 at 03:10:53AM +0000, Maciej W. Rozycki wrote:
> On Wed, 7 Nov 2018, Paul Burton wrote:
>
> > diff --git a/arch/mips/include/asm/cpu-features.h b/arch/mips/include/asm/cpu-features.h
> > index 0edba3e75747..8669fdb503a5 100644
> > --- a/arch/mips/include/asm/cpu-features.h
> > +++ b/arch/mips/include/asm/cpu-features.h
> > @@ -195,7 +195,9 @@
> > #endif
> >
> > #ifndef cpu_has_mmips
> > -# ifdef CONFIG_SYS_SUPPORTS_MICROMIPS
> > +# if defined(__mips_micromips)
>
> Wouldn't it be cleaner if it was written:
>
> # if defined(CONFIG_CPU_MICROMIPS)
I suppose it's just a matter of preference - in practice both ought to
be defined or undefined at the same times. My personal preference is the
standard macro provided by the compiler, so that's what I used.
Thanks,
Paul
