Hi Maksym,
On Tue, Nov 06, 2018 at 05:29:40PM +0200, Maksym Kokhan wrote:
> > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > > > index 3551199..71d6549 100644
> > > > > --- a/arch/mips/Kconfig
> > > > > +++ b/arch/mips/Kconfig
> > > > > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > > > > select USE_OF
> > > > > select LIBFDT
> > > > > select ZONE_DMA32 if 64BIT
> > > > > - select BUILTIN_DTB
> > > > > select LIBFDT
> > > >
> > > > LIBFDT seems duplicated too.
> > >
> > > Using random sort order doesn't help. Keep them sorted, please?
> >
> > We are going to deal with it in the separate patch.
>
> Is it OK to leave this patch as it is and make another patch/patches
> for other changes or it would be better to modify it to remove
> duplication of LIBFDT too and sort this list of configs?
My preference would be that you remove all the duplicates as one patch,
then sort the selects alphabetically in a second patch. That should be
granular enough to make it easy to review, but not so fine-grained that
it becomes annoying.
Thanks,
Paul
