On Thu, Oct 4, 2018 at 3:06 PM Maksym Kokhan <maksym.kokhan@xxxxxxxxxxxxxxx> wrote: > > On Thu, Oct 4, 2018 at 12:14 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > > > On Thu, Oct 4, 2018 at 10:38 AM Sergei Shtylyov > > <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > > > On 10/3/2018 8:23 PM, Maksym Kokhan wrote: > > > > CONFIG_BUILTIN_DTB selection is duplicated in menu > > > > "Machine selection" under MIPS_MALTA. > > > > > > > > Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT") > > > > Signed-off-by: Maksym Kokhan <maksym.kokhan@xxxxxxxxxxxxxxx> > > > > Signed-off-by: Andrii Bordunov <andrew.bordunov@xxxxxxxxx> > > > > --- > > > > arch/mips/Kconfig | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > > > > index 3551199..71d6549 100644 > > > > --- a/arch/mips/Kconfig > > > > +++ b/arch/mips/Kconfig > > > > @@ -539,7 +539,6 @@ config MIPS_MALTA > > > > select USE_OF > > > > select LIBFDT > > > > select ZONE_DMA32 if 64BIT > > > > - select BUILTIN_DTB > > > > select LIBFDT > > > > > > LIBFDT seems duplicated too. > > > > Using random sort order doesn't help. Keep them sorted, please? > > We are going to deal with it in the separate patch. Is it OK to leave this patch as it is and make another patch/patches for other changes or it would be better to modify it to remove duplication of LIBFDT too and sort this list of configs? -- Regards, Maksym Kokhan