On 31/07/2018 17:53:17+0300, Andy Shevchenko wrote: > On Tue, 2018-07-31 at 16:30 +0200, Alexandre Belloni wrote: > > On 31/07/2018 17:23:04+0300, Andy Shevchenko wrote: > > > On Tue, 2018-07-31 at 17:02 +0300, Andy Shevchenko wrote: > > > > On Tue, 2018-07-31 at 15:47 +0200, Alexandre Belloni wrote: > > > > > > + dev->flags |= (u32)device_get_match_data(&pdev->dev); > > > > > + > > > > > > And since it would be changed anyway, can you actually move this > > > line > > > closet to if (has_acpi_companion()) one ? > > > > > > > I need that value to be set before calling of_configure though. > > AFAICS, you added those lines later, so, it would be something like > > dev->flags |= ... > > if (of_node) > of_configure() > if (has_acpi_companion()) > acpi_configure() > > Would it work for you? > Works for me, I'll send v3 soon. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
