Hi Hauke, On Sat, Jul 21, 2018 at 09:13:57PM +0200, Hauke Mehrtens wrote: > diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c > index e0af39b33e28..c704312ef7d5 100644 > --- a/arch/mips/lantiq/xway/sysctrl.c > +++ b/arch/mips/lantiq/xway/sysctrl.c > @@ -536,7 +536,7 @@ void __init ltq_soc_init(void) > clkdev_add_pmu(NULL, "ahb", 1, 0, PMU_AHBM | PMU_AHBS); > > clkdev_add_pmu("1da00000.usif", "NULL", 1, 0, PMU_USIF); > - clkdev_add_pmu("1e108000.eth", NULL, 0, 0, > + clkdev_add_pmu("1e10b308.eth", NULL, 0, 0, > PMU_SWITCH | PMU_PPE_DPLUS | PMU_PPE_DPLUM | > PMU_PPE_EMA | PMU_PPE_TC | PMU_PPE_SLL01 | > PMU_PPE_QSB | PMU_PPE_TOP); Is this intentional? Why is it needed? Was the old address wrong? Does it change anything functionally? If it is needed it seems like a separate change - unless there's some reason it's tied to adding this driver? Should this really apply only to the lantiq,vr9 case or also to the similar lantiq,grx390 & lantiq,ar10 paths? Whatever the answers to these questions it would be good to include them in the commit message. Thanks, Paul